-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync upstream Dec 24th #4
base: main
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis PR updates Sequence diagram for footer link pages signal flowsequenceDiagram
participant Event as Event System
participant Signal as footer_link_pages Signal
participant Pages as Pages Plugin
participant URI as URI Builder
Event->>Signal: Send signal with event and request
Signal->>Pages: Process signal
Pages->>URI: build_absolute_uri()
URI-->>Pages: Return page URL
Note over Pages: Transform to use 'url' key
Pages-->>Signal: Return page info with url
Signal-->>Event: Return footer links
Class diagram showing signal interface changeclassDiagram
class FooterLinkResponse {
-title: string
-url: string
}
note for FooterLinkResponse "Changed 'link' to 'url' to match documented interface"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @HungNgien - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
548f83acef4065783f6daa73e72c7e2f76921225
Summary by Sourcery
Enhancements:
link
key withurl
in thefooter_link_pages
signal.