Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bits() in bitset_type before initialization #753

Merged
merged 4 commits into from
Jan 7, 2024
Merged

Fix bits() in bitset_type before initialization #753

merged 4 commits into from
Jan 7, 2024

Conversation

jvdp1
Copy link
Member

@jvdp1 jvdp1 commented Dec 25, 2023

Fixes #746

  • Addition of tests that trigger the bug with GFortran 11 and 12

Issue #746 reported by @degawa

@jvdp1 jvdp1 requested review from degawa, gnikit, Jim-215-Fisher and a team December 25, 2023 19:17
degawa
degawa approved these changes Dec 27, 2023
View reviewed changes
Copy link
Contributor

@degawa degawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that the issue #746 has been resolved in my environment.

I would like to thank you, @jvdp1, for fixing the CI/CD environment. I have been trying to resolve this issue, but it has been beyond my ability.

gnikit
gnikit approved these changes Dec 28, 2023
View reviewed changes
Copy link
Member

@gnikit gnikit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks @jvdp1

@gnikit
Copy link
Member

gnikit commented Dec 28, 2023

Let's wait a couple of days for any remaining reviews and I there are none I will merge it.

@jvdp1
Copy link
Member Author

jvdp1 commented Jan 7, 2024

I'll merge this PR. Thank you all for your contributions

@jvdp1 jvdp1 merged commit c086185 into fortran-lang:master Jan 7, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@degawa degawa degawa approved these changes

@gnikit gnikit gnikit approved these changes

@Jim-215-Fisher Jim-215-Fisher Awaiting requested review from Jim-215-Fisher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bits() in bitset_type returned a non-zero value even though no value is set.
3 participants
@jvdp1 @gnikit @degawa