Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cross matching on an aggregate or entity property #41

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

Baptouuuu
Copy link
Member

Problem

#37 introduced cross aggregate matching. However the PR only tested against an optional entity.

When applying this feature on an aggregate or entity property then it throws a LogicException with the SQL adapter saying the specification CrossMatch is not supported.

Solution

Add missing specification translations in the SQL adapter to allow to apply it in these cases.

@Baptouuuu Baptouuuu added bug Something isn't working SQL labels Oct 31, 2024
@Baptouuuu Baptouuuu self-assigned this Oct 31, 2024
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 8 lines in your changes missing coverage. Please review.

Project coverage is 97.21%. Comparing base (bade44f) to head (cdaebd6).

Files with missing lines Patch % Lines
src/Adapter/SQL/MainTable.php 42.85% 8 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop      #41      +/-   ##
=============================================
- Coverage      97.37%   97.21%   -0.16%     
- Complexity       635      637       +2     
=============================================
  Files             96       96              
  Lines           4337     4351      +14     
=============================================
+ Hits            4223     4230       +7     
- Misses           114      121       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Baptouuuu Baptouuuu merged commit 0b1ed42 into develop Oct 31, 2024
17 of 19 checks passed
@Baptouuuu Baptouuuu deleted the fix-cross-aggregate-matching branch October 31, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working SQL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant