Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce circular references #40

Merged
merged 2 commits into from
Oct 26, 2024
Merged

Reduce circular references #40

merged 2 commits into from
Oct 26, 2024

Conversation

Baptouuuu
Copy link
Member

Problem

Same as Innmind/framework#3

Solution

Same as Innmind/framework#3

Note

There are remaining closures that still capture $this but they should be directly evaluated, meaning the reference is short lived. This should not cause any problem.

@Baptouuuu Baptouuuu added the bug Something isn't working label Oct 26, 2024
@Baptouuuu Baptouuuu self-assigned this Oct 26, 2024
Copy link

codecov bot commented Oct 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.39%. Comparing base (076be6f) to head (0a2d5a2).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop      #40      +/-   ##
=============================================
+ Coverage      97.33%   97.39%   +0.06%     
- Complexity       634      635       +1     
=============================================
  Files             96       96              
  Lines           4236     4337     +101     
=============================================
+ Hits            4123     4224     +101     
  Misses           113      113              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Baptouuuu Baptouuuu merged commit b248646 into develop Oct 26, 2024
19 checks passed
@Baptouuuu Baptouuuu deleted the reduce-circular-references branch October 26, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant