Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ operator overloads for bitwise operators #1340

Merged
merged 6 commits into from
Jul 24, 2024
Merged

Conversation

trueqbit
Copy link
Collaborator

@trueqbit trueqbit commented Jul 23, 2024

This PR provides:

  • C++ operator overloads for bitwise operators.
  • the unary minus operator.
  • logical AND/OR operator is now negatable.

Additionally:

  • Added missing node_tuple specialization for bitwise_not_t.
  • Improved serializing logical and bitwise NOT.

The bitwise operators were missing C++ operator equivalents.
Also:
* Added serialization unit tests for bitwise operators
* Added missing column result type unit tests for bitwise operators
* Added missing serialization unit tests for logical not
* Improved parenthesizing logical and bitwise "not" expressions
@trueqbit trueqbit requested a review from fnc12 July 24, 2024 07:30
Copy link
Owner

@fnc12 fnc12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

das ist perfect

dev/operators.h Show resolved Hide resolved
@trueqbit trueqbit merged commit 2db5e0f into dev Jul 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants