Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pigeon] Adds platform for imports that aren't support on a platform #8338

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

bparrishMines
Copy link
Contributor

@bparrishMines bparrishMines commented Dec 22, 2024

While working on updating webview_flutter_wkwebview to use ProxyApis, the UIKit import would be invalid on macOS. This PR now surrounds ProxyApi imports with a check if every class of an import excludes a platform.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@bparrishMines bparrishMines changed the title Pigeon swift fixes [pigeon] Adds platform for imports that aren't support on a platform Dec 22, 2024
@bparrishMines bparrishMines marked this pull request as ready for review December 26, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant