Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dependabot]: Bump com.google.maps.android:android-maps-utils from 3.6.0 to 3.9.0 in /packages/google_maps_flutter/google_maps_flutter_android/android #8333

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 18, 2024

Bumps com.google.maps.android:android-maps-utils from 3.6.0 to 3.9.0.

Release notes

Sourced from com.google.maps.android:android-maps-utils's releases.

v3.9.0

3.9.0 (2024-10-28)

Bug Fixes

Features

  • Try to catch invalid map api keys in the demo (#1400) (fc7bada)

v3.8.2

3.8.2 (2023-12-20)

Bug Fixes

  • IllegalArgumentException is clearer than ArrayIndexOutOfBounds (#1241) (9c882be)

v3.8.1

3.8.1 (2023-12-20)

Bug Fixes

v3.8.0

3.8.0 (2023-11-06)

Features

  • added street view source parameter to fetchStreetViewData (#1262) (2fd3921)

v3.7.0

3.7.0 (2023-10-27)

Features

The upgraded renderer is required for Advanced Markers.

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [com.google.maps.android:android-maps-utils](https://github.com/googlemaps/android-maps-utils) from 3.6.0 to 3.9.0.
- [Release notes](https://github.com/googlemaps/android-maps-utils/releases)
- [Changelog](https://github.com/googlemaps/android-maps-utils/blob/main/.releaserc)
- [Commits](googlemaps/android-maps-utils@v3.6.0...v3.9.0)

---
updated-dependencies:
- dependency-name: com.google.maps.android:android-maps-utils
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from reidbaker as a code owner December 18, 2024 21:10
@dependabot dependabot bot added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 18, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 18, 2024
Copy link
Contributor

auto-submit bot commented Dec 18, 2024

auto label is removed for flutter/packages/8333, due to - The status or check suite Linux_android android_platform_tests_shard_1 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

  • The status or check suite Linux repo_checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

@jmagman
Copy link
Member

jmagman commented Dec 20, 2024

class file has wrong version 61.0, should be 55.0

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8728179632701685089/+/u/Run_package_tests/build_all_packages_for_Android_-_legacy_version/stdout

google_maps_flutter_android is minSdkVersion 20
https://github.com/flutter/packages/blob/3515abab07d0bb2441277f43c2411c9b5e4ecf94/packages/google_maps_flutter/google_maps_flutter_android/android/build.gradle#L29C9-L29C22

android-maps-utils 3.8.0 bumped requirement to Android API level 21+
googlemaps/android-maps-utils@v3.7.0...v3.8.0

#7882 is going to bump this to 3.7.0, which has advanced clustering support, but doesn't have an SDK bump.

It seems like maybe dependabot should be ignoring this dependency and it should be bumped manually as required to support maps features? @reidbaker wdyt?

@reidbaker
Copy link
Contributor

google_maps_flutter_android should set a min sdk version to at least 21 since that is what the last few flutter releases have required.
Class version 61 is saying we are building with java 17 but it is expecting java 11 (probably... I didnt look up 55). I think this is a test configuration issue. Either way manual update is probably required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants