updated README

florent37 · May 21, 2015 · f9a9126 · f9a9126
1 parent c6c22bf
commit f9a9126
Show file tree

Hide file tree

Showing 9 changed files with 123 additions and 320 deletions.
diff --git a/.idea/workspace.xml b/.idea/workspace.xml
diff --git a/README.md b/README.md
@@ -22,7 +22,7 @@ And have a look on a sample Youtube Video : [Youtube Link](http://www.youtube.co
 
 In your module [![Download](https://api.bintray.com/packages/florent37/maven/MaterialViewPager/images/download.svg)](https://bintray.com/florent37/maven/MaterialViewPager/_latestVersion)
 ```groovy
-compile ('com.github.florent37:materialviewpager:1.0.3.3@aar'){
+compile ('com.github.florent37:materialviewpager:1.0.4@aar'){
     transitive = true
 }
 ```
@@ -507,6 +507,14 @@ MaterialViewPagerHelper.registerListView(getActivity(), mListView, null);
 
 #CHANGELOG
 
+##1.0.4
+Fixed :
+
+- Orientation changed
+- Memory Leak
+- Android >2.3 with NineOldAndroid
+- Removed ListView usage
+
 ##1.0.3
 
 Fixed :  Rapid scrolling results in varying Toolbar height

diff --git a/materialviewpager/build.gradle b/materialviewpager/build.gradle
@@ -3,7 +3,7 @@ apply plugin: 'com.android.library'
 apply plugin: 'com.github.dcendents.android-maven'
 apply plugin: 'com.jfrog.bintray'
 
-version = "1.0.3.3"
+version = "1.0.4"
 
 
 android {

diff --git a/materialviewpager/materialviewpager.iml b/materialviewpager/materialviewpager.iml
@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<module external.linked.project.id=":materialviewpager" external.linked.project.path="$MODULE_DIR$" external.root.project.path="$MODULE_DIR$/.." external.system.id="GRADLE" external.system.module.group="com.github.florent37" external.system.module.version="1.0.3.3" type="JAVA_MODULE" version="4">
+<module external.linked.project.id=":materialviewpager" external.linked.project.path="$MODULE_DIR$" external.root.project.path="$MODULE_DIR$/.." external.system.id="GRADLE" external.system.module.group="com.github.florent37" external.system.module.version="1.0.4" type="JAVA_MODULE" version="4">
   <component name="FacetManager">
     <facet type="android-gradle" name="Android-Gradle">
       <configuration>

diff --git a/...pager/src/main/java/com/github/florent37/materialviewpager/MaterialViewPagerAnimator.java b/...pager/src/main/java/com/github/florent37/materialviewpager/MaterialViewPagerAnimator.java
@@ -10,7 +10,6 @@
 import android.widget.ListView;
 import android.widget.ScrollView;
 
-import com.github.ksoichiro.android.observablescrollview.ObservableListView;
 import com.github.ksoichiro.android.observablescrollview.ObservableScrollView;
 import com.github.ksoichiro.android.observablescrollview.ObservableScrollViewCallbacks;
 import com.github.ksoichiro.android.observablescrollview.ObservableWebView;
@@ -552,52 +551,6 @@ public void onUpOrCancelMotionEvent(ScrollState scrollState) {
         }
     }
 
-    /**
-     * Register a ListView to the current MaterialViewPagerAnimator
-     * Listen to ObservableScrollViewCallbacks so give to $[observableScrollViewCallbacks] your ObservableScrollViewCallbacks if you already use one
-     * For loadmore or anything else
-     *
-     * @param listView                      the scrollable
-     * @param observableScrollViewCallbacks use it if you want to get a callback of the RecyclerView
-     */
-    @Deprecated
-    public void registerListView(final ObservableListView listView, final ObservableScrollViewCallbacks observableScrollViewCallbacks) {
-        if (listView != null) {
-            if (listView.getParent() != null && listView.getParent().getParent() != null && listView.getParent().getParent() instanceof ViewGroup)
-                listView.setTouchInterceptionViewGroup((ViewGroup) listView.getParent().getParent());
-            scrollViewList.add(listView);  //add to the scrollable list
-            listView.setScrollViewCallbacks(new ObservableScrollViewCallbacks() {
-                @Override
-                public void onScrollChanged(int i, boolean b, boolean b2) {
-                    if (observableScrollViewCallbacks != null)
-                        observableScrollViewCallbacks.onScrollChanged(i, b, b2);
-
-                    //if scrolled from dispatch, remove & return -> so skip
-                    if (calledScrollList.contains(listView)) {
-                        calledScrollList.remove(listView);
-                        return;
-                    }
-
-                    onMaterialScrolled(listView, i);
-                }
-
-                @Override
-                public void onDownMotionEvent() {
-                    if (observableScrollViewCallbacks != null)
-                        observableScrollViewCallbacks.onDownMotionEvent();
-                }
-
-                @Override
-                public void onUpOrCancelMotionEvent(ScrollState scrollState) {
-                    if (observableScrollViewCallbacks != null)
-                        observableScrollViewCallbacks.onUpOrCancelMotionEvent(scrollState);
-                }
-            });
-
-            this.setScrollOffset(listView, lastYOffset);
-        }
-    }
-
     //endregion
 
     public void restoreScroll(float scroll,MaterialViewPagerSettings settings) {

diff --git a/...ewpager/src/main/java/com/github/florent37/materialviewpager/MaterialViewPagerHelper.java b/...ewpager/src/main/java/com/github/florent37/materialviewpager/MaterialViewPagerHelper.java
@@ -80,25 +80,6 @@ public static void registerWebView(Activity activity, ObservableWebView webView,
         }
     }
 
-    /**
-     * Register a ListView to the current MaterialViewPagerAnimator
-     * Listen to ObservableScrollViewCallbacks so give to $[observableScrollViewCallbacks] your ObservableScrollViewCallbacks if you already use one
-     * For loadmore or anything else
-     *
-     * @param activity                      current context
-     * @param listView                      the scrollable
-     * @param observableScrollViewCallbacks use it if you want to get a callback of the RecyclerView
-     */
-    @Deprecated
-    public static void registerListView(Activity activity, ObservableListView listView, ObservableScrollViewCallbacks observableScrollViewCallbacks) {
-        if (activity != null && hashMap.containsKey(activity)) {
-            MaterialViewPagerAnimator animator = hashMap.get(activity);
-            if (animator != null) {
-                animator.registerListView(listView, observableScrollViewCallbacks);
-            }
-        }
-    }
-
     /**
      * Register a ScrollView to the current MaterialViewPagerAnimator
      * Listen to ObservableScrollViewCallbacks so give to $[observableScrollViewCallbacks] your ObservableScrollViewCallbacks if you already use one

diff --git a/...src/main/java/com/github/florent37/materialviewpager/adapter/ListViewMaterialAdapter.java b/...src/main/java/com/github/florent37/materialviewpager/adapter/ListViewMaterialAdapter.java
diff --git a/sample/src/main/java/com/github/florent37/materialviewpager/sample/MainActivity.java b/sample/src/main/java/com/github/florent37/materialviewpager/sample/MainActivity.java
@@ -8,16 +8,11 @@
 import android.support.v7.app.ActionBarActivity;
 import android.support.v7.app.ActionBarDrawerToggle;
 import android.support.v7.widget.Toolbar;
-import android.view.Menu;
 import android.view.ViewGroup;
 
 import com.github.florent37.materialviewpager.MaterialViewPager;
-import com.github.florent37.materialviewpager.MaterialViewPagerHelper;
-import com.github.florent37.materialviewpager.MaterialViewPagerImageHeader;
-import com.github.florent37.materialviewpager.sample.fragment.ListViewFragment;
 import com.github.florent37.materialviewpager.sample.fragment.RecyclerViewFragment;
 import com.github.florent37.materialviewpager.sample.fragment.ScrollFragment;
-import com.github.florent37.materialviewpager.sample.fragment.WebViewFragment;
 
 public class MainActivity extends ActionBarActivity {
 
@@ -67,8 +62,6 @@ public Fragment getItem(int position) {
                     case 1:
                         return ScrollFragment.newInstance();
                     //case 2:
-                    //    return ListViewFragment.newInstance();
-                    //case 3:
                     //    return WebViewFragment.newInstance();
                     default:
                         return RecyclerViewFragment.newInstance();
@@ -80,13 +73,13 @@ public void setPrimaryItem(ViewGroup container, int position, Object object) {
                 super.setPrimaryItem(container, position, object);
 
                 //only if position changed
-                if(position == oldPosition)
+                if (position == oldPosition)
                     return;
                 oldPosition = position;
 
                 int color = 0;
                 String imageUrl = "";
-                switch (position){
+                switch (position) {
                     case 0:
                         imageUrl = "http://cdn1.tnwcdn.com/wp-content/blogs.dir/1/files/2014/06/wallpaper_51.jpg";
                         color = getResources().getColor(R.color.blue);
@@ -106,8 +99,8 @@ public void setPrimaryItem(ViewGroup container, int position, Object object) {
                 }
 
                 final int fadeDuration = 400;
-                mViewPager.setImageUrl(imageUrl,fadeDuration);
-                mViewPager.setColor(color,fadeDuration);
+                mViewPager.setImageUrl(imageUrl, fadeDuration);
+                mViewPager.setColor(color, fadeDuration);
 
             }
 
@@ -118,7 +111,7 @@ public int getCount() {
 
             @Override
             public CharSequence getPageTitle(int position) {
-                switch (position){
+                switch (position) {
                     case 0:
                         return "Selection";
                     case 1:

diff --git a/...rc/main/java/com/github/florent37/materialviewpager/sample/fragment/ListViewFragment.java b/...rc/main/java/com/github/florent37/materialviewpager/sample/fragment/ListViewFragment.java