Remove QT+GNOME+Wayland 'xcb' hack on fixed Qt versions #3683
Conversation
We implement code on GNOME desktops to force the QT_QPA_PLATFORM to be 'xcb'; this works around a clipboard-related bug on GNOME+Wayland+Qt. This bug was fixed (or worked around) in Qt 5.15.2, so we implement a version check; if the runtime Qt version is < 5.15.2, still force the workaround; otherwise, we don't need the workaround so we skip it.
|
Is @mmahmoudian or anyone else available to review this PR/provide feedback on it? |
|
Thanks, the code looks clean and make sense to me and I believe it is small enough that I can merge it without waiting for other devs.
I'll merge it now. Thanks for your detailed contribution and providing references and details. |
|
I'm so confused on why GithubActions are not running for this PR! I'm also merging #3725 and that one is running all the CIs. I need to make sure all CIs pass before merging. |
|
@mmahmoudian I added another commit (with clang-format updates), and it says "This workflow requires approval from a maintainer", and links to this document. Perhaps that's what's missing? |
We implement code on GNOME desktops to force
QT_QPA_PLATFORMtoxcb; this works around a clipboard-related bug on GNOME+Wayland+Qt.This bug was fixed (or worked around) in Qt 5.15.2, so we implement a version check; if the runtime Qt version is < 5.15.2, still force the workaround; otherwise, we don't need the workaround so we skip it.
We also add logging output so that users attempting to force the app not to use xcb won't get confused (as I did).
Note that the original discussion on this issue was in ksnip/ksnip#416, which indicates when this issue was fixed in Qt.