-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial implementation of the plugin framework #3661
Open
jack9603301
wants to merge
3
commits into
flameshot-org:master
Choose a base branch
from
jack9603301:feature/plugin-RFC
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jack9603301
commented
Jul 5, 2024
•
edited
Loading
edited
- Plugin RFC Plugin RFC #2529
- Printer support and save to PDF support
Plugin RFC flameshot-org#2529 Signed-off-by: Ouyang Chunhui <[email protected]>
jack9603301
force-pushed
the
feature/plugin-RFC
branch
from
July 5, 2024 09:40
5286322
to
650f7c0
Compare
mmahmoudian
reviewed
Jul 5, 2024
jack9603301
force-pushed
the
feature/plugin-RFC
branch
from
July 5, 2024 10:14
0c095b4
to
e9e13dc
Compare
This framework will introduce a new dependency: yaml-cpp |
jack9603301
force-pushed
the
feature/plugin-RFC
branch
from
July 5, 2024 10:32
e9e13dc
to
0bf17e0
Compare
This is to counter PR checks, because it seems that the PR's qt environment does not support some specific parameters of this function - the latest version of qt5 compiles fine on Linux Signed-off-by: Ouyang Chunhui <[email protected]>
jack9603301
force-pushed
the
feature/plugin-RFC
branch
from
July 5, 2024 10:34
0bf17e0
to
66327f9
Compare
Since the plugin manager is an experimental feature, the compilation flag is turned off by default. Signed-off-by: Ouyang Chunhui <[email protected]>
@panpuchkov Can you take a look at this PR? |
If we go with a plugin system, why do we need to have multiple |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.