Skip to content

Commit

Permalink
cleaned up naming scheme (for real this time)
Browse files Browse the repository at this point in the history
  • Loading branch information
FelixJochems committed Oct 7, 2024
1 parent c4ffb91 commit 2461e72
Show file tree
Hide file tree
Showing 5 changed files with 16 additions and 16 deletions.
20 changes: 10 additions & 10 deletions src/config/generalconf.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ GeneralConf::GeneralConf(QWidget* parent)
initUploadClientSecret();
initPredefinedColorPaletteLarge();
initShowSelectionGeometry();
initCountingCircleNoContrast();
initDisableCountingCircleContrast();

m_layout->addStretch();

Expand All @@ -83,7 +83,7 @@ void GeneralConf::_updateComponents(bool allowEmptySavePath)
m_copyPathAfterSave->setChecked(config.copyPathAfterSave());
m_antialiasingPinZoom->setChecked(config.antialiasingPinZoom());
m_useJpgForClipboard->setChecked(config.useJpgForClipboard());
m_countingCircleNoContrast->setChecked(config.countingCircleNoContrast());
m_disableCountingCircleContrast->setChecked(config.disableCountingCircleContrast());
m_copyOnDoubleClick->setChecked(config.copyOnDoubleClick());
m_uploadWithoutConfirmation->setChecked(config.uploadWithoutConfirmation());
m_historyConfirmationToDelete->setChecked(
Expand Down Expand Up @@ -152,9 +152,9 @@ void GeneralConf::allowMultipleGuiInstancesChanged(bool checked)
ConfigHandler().setAllowMultipleGuiInstances(checked);
}

void GeneralConf::setCountingCircleNoContrast(bool checked)
void GeneralConf::setDisableCountingCircleContrast(bool checked)
{
ConfigHandler().setCountingCircleNoContrast(checked);
ConfigHandler().setDisableCountingCircleContrast(checked);
}
void GeneralConf::autoCloseIdleDaemonChanged(bool checked)
{
Expand Down Expand Up @@ -805,16 +805,16 @@ void GeneralConf::initJpegQuality()
&GeneralConf::setJpegQuality);
}

void GeneralConf::initCountingCircleNoContrast()
void GeneralConf::initDisableCountingCircleContrast()
{
m_countingCircleNoContrast = new QCheckBox(tr("Disable contrast on the counting bubble"), this);
m_countingCircleNoContrast->setToolTip(
m_disableCountingCircleContrast = new QCheckBox(tr("Disable contrast on the counting bubble"), this);
m_disableCountingCircleContrast->setToolTip(
tr("Disable the contrasting circle that is around the counting circle tool when it has no arrow"));
m_scrollAreaLayout->addWidget(m_countingCircleNoContrast);
connect(m_countingCircleNoContrast,
m_scrollAreaLayout->addWidget(m_disableCountingCircleContrast);
connect(m_disableCountingCircleContrast,
&QCheckBox::clicked,
this,
&GeneralConf::setCountingCircleNoContrast);}
&GeneralConf::setDisableCountingCircleContrast);}

void GeneralConf::setSelGeoHideTime(int v)
{
Expand Down
6 changes: 3 additions & 3 deletions src/config/generalconf.h
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ private slots:
void setGeometryLocation(int index);
void setSelGeoHideTime(int v);
void setJpegQuality(int v);
void setCountingCircleNoContrast(bool checked);
void setDisableCountingCircleContrast(bool checked);

private:
const QString chooseFolder(const QString& currentPath = "");
Expand Down Expand Up @@ -93,7 +93,7 @@ private slots:
void initSaveLastRegion();
void initShowSelectionGeometry();
void initJpegQuality();
void initCountingCircleNoContrast();
void initDisableCountingCircleContrast();

void _updateComponents(bool allowEmptySavePath);

Expand Down Expand Up @@ -138,5 +138,5 @@ private slots:
QComboBox* m_selectGeometryLocation;
QSpinBox* m_xywhTimeout;
QSpinBox* m_jpegQuality;
QCheckBox* m_countingCircleNoContrast;
QCheckBox* m_disableCountingCircleContrast;
};
2 changes: 1 addition & 1 deletion src/tools/circlecount/circlecounttool.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ void CircleCountTool::process(QPainter& painter, const QPixmap& pixmap)
}
painter.setPen(contrastColor);
painter.setBrush(antiContrastColor);
if(ConfigHandler().countingCircleNoContrast())
if(ConfigHandler().disableCountingCircleContrast())
{
if(line.length() < bubble_size)
{
Expand Down
2 changes: 1 addition & 1 deletion src/utils/confighandler.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ static QMap<class QString, QSharedPointer<ValueHandler>>
OPTION("showDesktopNotification" ,Bool ( true )),
OPTION("disabledTrayIcon" ,Bool ( false )),
OPTION("disabledGrimWarning" ,Bool ( false )),
OPTION("countingCircleNoContrast" ,Bool ( false )),
OPTION("disableCountingCircleContrast" ,Bool ( false )),
OPTION("historyConfirmationToDelete" ,Bool ( true )),
#if !defined(DISABLE_UPDATE_CHECKER)
OPTION("checkForUpdates" ,Bool ( true )),
Expand Down
2 changes: 1 addition & 1 deletion src/utils/confighandler.h
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ class ConfigHandler : public QObject
CONFIG_GETTER_SETTER(filenamePattern, setFilenamePattern, QString)
CONFIG_GETTER_SETTER(disabledTrayIcon, setDisabledTrayIcon, bool)
CONFIG_GETTER_SETTER(disabledGrimWarning, disabledGrimWarning, bool)
CONFIG_GETTER_SETTER(countingCircleNoContrast, setCountingCircleNoContrast, bool)
CONFIG_GETTER_SETTER(disableCountingCircleContrast, setDisableCountingCircleContrast, bool)
CONFIG_GETTER_SETTER(drawThickness, setDrawThickness, int)
CONFIG_GETTER_SETTER(drawFontSize, setDrawFontSize, int)
CONFIG_GETTER_SETTER(keepOpenAppLauncher, setKeepOpenAppLauncher, bool)
Expand Down

0 comments on commit 2461e72

Please sign in to comment.