Consolidate CI test output into a single string #8489

dlarocque · 2024-09-09T15:42:10Z

Having the stdout and stderr in a single string makes it easier to read when analyzing test failures. Currently if there's a test failure, we output stdout and stderr separately so we can't tell which errors were logged during which test.

For example, in https://github.com/firebase/firebase-js-sdk/actions/runs/10776099172/job/29882046607, there are tons of FIREBASE FATAL ERROR's logged, but I can't tell which tests are logging these errors, or if they're even what's causing the tests to fail.

Having CI test process stdout and stderr in a single string makes it easier to read when looking through failures, since you can see the test output alongside the error messages. Without this, any stderr output written during a test will be captured seperately from the test output, so when we then log it after a test failure, we can't tell which test logged which errors.

changeset-bot · 2024-09-09T15:42:14Z

⚠️ No Changeset found

Latest commit: 137254e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

google-oss-bot · 2024-09-09T15:57:46Z

Size Report ¹

Affected Products

@firebase/app
Type Base (3670ab8) Merge (384106b) Diff
browser 18.3 kB 18.4 kB +67 B (+0.4%)
esm5 24.0 kB 24.1 kB +69 B (+0.3%)
main 25.1 kB 25.2 kB +69 B (+0.3%)
module 18.3 kB 18.4 kB +67 B (+0.4%)

`@firebase/auth`

Type	Base (`3670ab8`)	Merge (`384106b`)	Diff
browser	182 kB	182 kB	+81 B (+0.0%)
cordova	209 kB	209 kB	+85 B (+0.0%)
esm5	236 kB	236 kB	+85 B (+0.0%)
main	179 kB	179 kB	+71 B (+0.0%)
module	182 kB	182 kB	+81 B (+0.0%)
react-native	199 kB	199 kB	+71 B (+0.0%)

@firebase/auth-cordova
Type Base (3670ab8) Merge (384106b) Diff
browser 209 kB 209 kB +85 B (+0.0%)
module 209 kB 209 kB +85 B (+0.0%)
@firebase/auth-web-extension
Type Base (3670ab8) Merge (384106b) Diff
browser 137 kB 137 kB +81 B (+0.1%)
main 152 kB 152 kB +69 B (+0.0%)
module 137 kB 137 kB +81 B (+0.1%)
@firebase/auth/internal
Type Base (3670ab8) Merge (384106b) Diff
browser 193 kB 193 kB +81 B (+0.0%)
esm5 249 kB 249 kB +85 B (+0.0%)
main 214 kB 214 kB +73 B (+0.0%)
module 193 kB 193 kB +81 B (+0.0%)
@firebase/data-connect
Type Base (3670ab8) Merge (384106b) Diff
browser ? 19.8 kB ? (?)
esm5 ? 22.5 kB ? (?)
main ? 24.3 kB ? (?)
module ? 19.8 kB ? (?)
@firebase/firestore
Type Base (3670ab8) Merge (384106b) Diff
browser 381 kB 381 kB -329 B (-0.1%)
esm5 366 kB 366 kB +107 B (+0.0%)
main 587 kB 587 kB +357 B (+0.1%)
module 381 kB 381 kB -329 B (-0.1%)
react-native 382 kB 381 kB -328 B (-0.1%)
@firebase/firestore-lite
Type Base (3670ab8) Merge (384106b) Diff
browser 111 kB 111 kB +179 B (+0.2%)
esm5 108 kB 108 kB +399 B (+0.4%)
main 153 kB 153 kB +193 B (+0.1%)
module 111 kB 111 kB +179 B (+0.2%)
react-native 111 kB 111 kB +179 B (+0.2%)
@firebase/util
Type Base (3670ab8) Merge (384106b) Diff
browser 23.2 kB 23.4 kB +131 B (+0.6%)
esm5 24.9 kB 25.0 kB +131 B (+0.5%)
main 30.7 kB 30.9 kB +233 B (+0.8%)
module 23.2 kB 23.4 kB +131 B (+0.6%)

`bundle`

46 size changes

Type	Base (`3670ab8`)	Merge (`384106b`)	Diff
analytics (logEvent)	44.5 kB	44.6 kB	+59 B (+0.1%)
app-check (CustomProvider)	37.4 kB	37.5 kB	+59 B (+0.2%)
app-check (ReCaptchaEnterpriseProvider)	39.9 kB	40.0 kB	+59 B (+0.1%)
app-check (ReCaptchaV3Provider)	39.9 kB	40.0 kB	+59 B (+0.1%)
auth (Anonymous)	76.1 kB	76.3 kB	+178 B (+0.2%)
auth (EmailAndPassword)	84.4 kB	84.6 kB	+178 B (+0.2%)
auth (GoogleFBTwitterGitHubPopup)	103 kB	103 kB	+177 B (+0.2%)
auth (GooglePopup)	100 kB	100 kB	+178 B (+0.2%)
auth (GoogleRedirect)	100 kB	100 kB	+178 B (+0.2%)
auth (Phone)	86.8 kB	86.9 kB	+178 B (+0.2%)
database (Append to a list of data)	149 kB	149 kB	+59 B (+0.0%)
database (Filtering data)	148 kB	148 kB	+59 B (+0.0%)
database (Listen for child events)	164 kB	164 kB	+59 B (+0.0%)
database (Listen for value events + Detach listeners)	164 kB	164 kB	+59 B (+0.0%)
database (Listen for value events)	164 kB	164 kB	+59 B (+0.0%)
database (Read data once)	164 kB	164 kB	+59 B (+0.0%)
database (Save data as transactions)	166 kB	166 kB	+59 B (+0.0%)
database (Sort data)	150 kB	150 kB	+59 B (+0.0%)
database (Write data)	148 kB	148 kB	+59 B (+0.0%)
firestore (CSI Auto Indexing Disable and Delete)	270 kB	270 kB	-597 B (-0.2%)
firestore (CSI Auto Indexing Enable)	270 kB	270 kB	-597 B (-0.2%)
firestore (Persistence)	305 kB	303 kB	-1.76 kB (-0.6%)
firestore (Query Cursors)	242 kB	242 kB	+321 B (+0.1%)
firestore (Query)	240 kB	240 kB	+321 B (+0.1%)
firestore (Read data once)	228 kB	228 kB	+321 B (+0.1%)
firestore (Read Write w Persistence)	325 kB	325 kB	+28 B (+0.0%)
firestore (Realtime updates)	230 kB	230 kB	+314 B (+0.1%)
firestore (Transaction)	207 kB	207 kB	+314 B (+0.2%)
firestore (Write data)	207 kB	207 kB	+314 B (+0.2%)
firestore-lite (Query Cursors)	91.3 kB	91.5 kB	+235 B (+0.3%)
firestore-lite (Query)	87.4 kB	87.6 kB	+235 B (+0.3%)
firestore-lite (Read data once)	62.9 kB	63.1 kB	+235 B (+0.4%)
firestore-lite (Transaction)	88.1 kB	88.4 kB	+238 B (+0.3%)
firestore-lite (Write data)	72.5 kB	72.7 kB	+235 B (+0.3%)
functions (call)	32.0 kB	32.0 kB	+59 B (+0.2%)
messaging (send + receive)	46.9 kB	47.0 kB	+59 B (+0.1%)
performance (trace)	51.8 kB	51.8 kB	+59 B (+0.1%)
remote-config (getAndFetch)	46.3 kB	46.3 kB	+59 B (+0.1%)
storage (getBytes)	42.1 kB	42.1 kB	+59 B (+0.1%)
storage (getDownloadURL)	44.1 kB	44.2 kB	+59 B (+0.1%)
storage (getMetadata)	43.6 kB	43.7 kB	+59 B (+0.1%)
storage (list + listAll)	43.0 kB	43.1 kB	+59 B (+0.1%)
storage (updateMetadata)	43.9 kB	43.9 kB	+59 B (+0.1%)
storage (uploadBytes)	48.7 kB	48.8 kB	+59 B (+0.1%)
storage (uploadBytesResumable)	58.7 kB	58.7 kB	+59 B (+0.1%)
storage (uploadString)	48.9 kB	49.0 kB	+59 B (+0.1%)

`firebase`

13 size changes

Type	Base (`3670ab8`)	Merge (`384106b`)	Diff
firebase-app-compat.js	31.8 kB	31.8 kB	+45 B (+0.1%)
firebase-app.js	103 kB	103 kB	+80 B (+0.1%)
firebase-auth-compat.js	139 kB	139 kB	+88 B (+0.1%)
firebase-auth-cordova.js	177 kB	177 kB	+124 B (+0.1%)
firebase-auth-web-extension.js	117 kB	117 kB	+128 B (+0.1%)
firebase-auth.js	151 kB	151 kB	+128 B (+0.1%)
firebase-compat.js	788 kB	788 kB	+13 B (+0.0%)
firebase-data-connect.js	?	16.5 kB	? (?)
firebase-firestore-compat.js	344 kB	344 kB	-118 B (-0.0%)
firebase-firestore-lite.js	119 kB	119 kB	+179 B (+0.2%)
firebase-firestore.js	440 kB	440 kB	-292 B (-0.1%)
firebase-performance-standalone-compat.es2017.js	93.6 kB	93.7 kB	+45 B (+0.0%)
firebase-performance-standalone-compat.js	70.8 kB	70.8 kB	+49 B (+0.1%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/5aDHaYJKyu.html

google-oss-bot · 2024-09-09T16:10:42Z

Size Analysis Report ¹

This report is too large (1,242,802 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/mDVRQKNwbJ.html

DellaBitta · 2024-09-09T19:04:46Z

I'm going to defer to @hsubox76 on this one. Perhaps there was a reason to keep them separated originally?

scripts/run_tests_in_ci.js

dlarocque requested review from DellaBitta and hsubox76 September 9, 2024 15:42

dlarocque requested a review from a team as a code owner September 9, 2024 15:42

hsubox76 reviewed Sep 16, 2024

View reviewed changes

scripts/run_tests_in_ci.js Outdated Show resolved Hide resolved

Prefix stdout and stderr output

137254e

dlarocque requested a review from hsubox76 September 25, 2024 14:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Consolidate CI test output into a single string #8489

Consolidate CI test output into a single string #8489

dlarocque commented Sep 9, 2024 •

edited

Loading

changeset-bot bot commented Sep 9, 2024 •

edited

Loading

google-oss-bot commented Sep 9, 2024 •

edited

Loading

`@firebase/app`

`@firebase/auth`

`@firebase/auth-cordova`

`@firebase/auth-web-extension`

`@firebase/auth/internal`

`@firebase/data-connect`

`@firebase/firestore`

`@firebase/firestore-lite`

`@firebase/util`

`bundle`

`firebase`

google-oss-bot commented Sep 9, 2024 •

edited

Loading

DellaBitta commented Sep 9, 2024

Consolidate CI test output into a single string #8489

Are you sure you want to change the base?

Consolidate CI test output into a single string #8489

Conversation

dlarocque commented Sep 9, 2024 • edited Loading

changeset-bot bot commented Sep 9, 2024 • edited Loading

⚠️ No Changeset found

google-oss-bot commented Sep 9, 2024 • edited Loading

Size Report 1

Affected Products

@firebase/app

@firebase/auth

@firebase/auth-cordova

@firebase/auth-web-extension

@firebase/auth/internal

@firebase/data-connect

@firebase/firestore

@firebase/firestore-lite

@firebase/util

bundle

firebase

Test Logs

google-oss-bot commented Sep 9, 2024 • edited Loading

Size Analysis Report 1

Test Logs

DellaBitta commented Sep 9, 2024

dlarocque commented Sep 9, 2024 •

edited

Loading

changeset-bot bot commented Sep 9, 2024 •

edited

Loading

google-oss-bot commented Sep 9, 2024 •

edited

Loading

Size Report ¹

`@firebase/app`

`@firebase/auth`

`@firebase/auth-cordova`

`@firebase/auth-web-extension`

`@firebase/auth/internal`

`@firebase/data-connect`

`@firebase/firestore`

`@firebase/firestore-lite`

`@firebase/util`

`bundle`

`firebase`

google-oss-bot commented Sep 9, 2024 •

edited

Loading

Size Analysis Report ¹