Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix dataSpace analytics #966

Merged
merged 1 commit into from
Sep 24, 2022
Merged

fix dataSpace analytics #966

merged 1 commit into from
Sep 24, 2022

Conversation

MauricioUyaguari
Copy link
Member

@MauricioUyaguari MauricioUyaguari commented Sep 23, 2022 •
edited
Loading

What type of PR is this?

Bug fix for dataSpace Analytics (#833)

What does this PR do / why is it needed ?

  • Handles analyze dataSpace for production PureClientVersion.
  • Handles metamodel transformations for PureClientVersions.production
  • Adds tests for PureClientVersions.production

Which issue(s) this PR fixes:

Related to finos/legend-sdlc#504

Other notes for reviewers:

Does this PR introduce a user-facing change?

Not by itself. Requires changes in depot to be complete.

@MauricioUyaguari MauricioUyaguari added the bug Something isn't working label Sep 23, 2022
@MauricioUyaguari MauricioUyaguari marked this pull request as ready for review September 23, 2022 15:05
@github-actions
Copy link

github-actions bot commented Sep 23, 2022 •
edited
Loading

Test Results

   313 files  ±0     313 suites  ±0   2h 32m 3s ⏱️ + 34m 7s
7 074 tests ±0  7 040 ✔️ ±0  34 💤 ±0  0 ❌ ±0 
8 413 runs  ±0  8 379 ✔️ ±0  34 💤 ±0  0 ❌ ±0 

Results for commit f16a44e. ± Comparison against base commit 02af2f7.

♻️ This comment has been updated with latest results.

@MauricioUyaguari MauricioUyaguari force-pushed the smallDataSpace branch 4 times, most recently from 3772aeb to e8a29c7 Compare September 23, 2022 19:23
rafaelbey
rafaelbey approved these changes Sep 23, 2022
View reviewed changes
Copy link
Contributor

@rafaelbey rafaelbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding test cases for all supported versions.

@rafaelbey rafaelbey merged commit ced38ac into finos:master Sep 24, 2022
@akphi akphi deleted the smallDataSpace branch September 24, 2022 02:58
@MauricioUyaguari MauricioUyaguari mentioned this pull request Oct 3, 2022
Merged
hausea pushed a commit to hausea/legend-engine that referenced this pull request Feb 8, 2023
@MauricioUyaguari @hausea
fix dataSpace analytics (finos#966)
35c893f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akphi akphi akphi approved these changes

@rafaelbey rafaelbey rafaelbey approved these changes

@pierredebelen pierredebelen Awaiting requested review from pierredebelen

@davidharte-gs davidharte-gs Awaiting requested review from davidharte-gs

@aormerod-gs aormerod-gs Awaiting requested review from aormerod-gs

@gs-ssh16 gs-ssh16 Awaiting requested review from gs-ssh16

@epsstan epsstan Awaiting requested review from epsstan

@kevin-m-knight-gs kevin-m-knight-gs Awaiting requested review from kevin-m-knight-gs

@aziemchawdhary-gs aziemchawdhary-gs Awaiting requested review from aziemchawdhary-gs

@elopezcastro elopezcastro Awaiting requested review from elopezcastro

Assignees
No one assigned
Labels
bug Something isn't working cla-present
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MauricioUyaguari @akphi @rafaelbey