Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding-normalize.css issue #889 #895

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

omesh-omg
Copy link
Contributor

this PR resolves issue #868
Adding normalize.css
inorder to have consistency across browsers

Copy link

netlify bot commented May 20, 2024

Deploy Preview for glistening-gecko-6b417a ready!

Name Link
🔨 Latest commit 27882a7
🔍 Latest deploy log https://app.netlify.com/sites/glistening-gecko-6b417a/deploys/664b921acbfaa60009af28b3
😎 Deploy Preview https://deploy-preview-895--glistening-gecko-6b417a.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aaronreed708
Copy link
Contributor

aaronreed708 commented May 21, 2024

Is this change ready to try? I tried the Deploy Preview on Netlify above and I don't see a change in behavior here. I still see the 3rd row below the bottom of the browser window.

Also, please ensure that the new .css file doesn't change/break any CSS that Theme Builder adds to the app.

@omesh-omg
Copy link
Contributor Author

No I wanted to check preview in safari rest I will have to go through again

@Sweetdevil144
Copy link
Contributor

I'm not able to detect any MAJOR changes as applied. Can you confirm it once again?

@omesh-omg
Copy link
Contributor Author

Yes, It's difficult to debug without having safari I am going through the material code itself if I can find something. Thanks for helping, meanwhile if you can check it locally btw if there are any changes u can see in primary color drop-down?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants