Skip to content

Commit

Permalink
Merge pull request #284 from fingerprintjs/ci/fix_workflows
Browse files Browse the repository at this point in the history
ci: fix comments
  • Loading branch information
necipallef authored Sep 17, 2024
2 parents a4dc5d7 + e719ef2 commit 18e9e07
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/e2e_test_branch.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,14 @@ permissions:

jobs:
run-e2e-for-test-branch:
name: Run e2e for test branch
runs-on: ubuntu-latest
if: ${{ github.event.workflow_run.conclusion == 'success' }}
steps:
- name: Git clone
uses: actions/checkout@v4
- name: configure AWS credentials
uses: aws-actions/configure-aws-credentials@e3dd6a429d7300a6a4c196c26e071d42e0343502 // #v4.0.2
uses: aws-actions/configure-aws-credentials@e3dd6a429d7300a6a4c196c26e071d42e0343502 #v4.0.2
with:
role-to-assume: ${{secrets.AWS_E2E_ROLE_ARN}}
aws-region: ${{secrets.AWS_E2E_REGION}}
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/e2e_test_for_releases.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,13 @@ permissions:

jobs:
run-e2e-for-releases-and-pre-releases:
name: Run e2e for releases and pre-releases
runs-on: ubuntu-latest
steps:
- name: Git clone
uses: actions/checkout@v4
- name: configure AWS credentials
uses: aws-actions/configure-aws-credentials@e3dd6a429d7300a6a4c196c26e071d42e0343502 // #v4.0.2
uses: aws-actions/configure-aws-credentials@e3dd6a429d7300a6a4c196c26e071d42e0343502 #v4.0.2
with:
role-to-assume: ${{secrets.AWS_E2E_ROLE_ARN}}
aws-region: ${{secrets.AWS_E2E_REGION}}
Expand Down

0 comments on commit 18e9e07

Please sign in to comment.