Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: XLSX Writer Options #14411

Merged
merged 6 commits into from
Oct 7, 2024

Conversation

mmonari
Copy link

@mmonari mmonari commented Oct 1, 2024

Description

This PR adds a getXlsxOptions() method to the Exporter class to allow users to further customize their exported XLSX documents, such as column widths, or any other OpenSpout\Writer\XLSX options as documented at the OpenSpout Documentation

Code style

  • Code style has been fixed by running the composer cs command.

Testing

  • Changes have been tested to not break existing functionality.

Documentation

  • Documentation is up-to-date.

Note:

As this is my first PR, I appreciate your understanding regarding my commit history. The first one represents the actual changes, the second was after executing a composer cs and it should have been described differently.

@mmonari
Copy link
Author

mmonari commented Oct 2, 2024

Ping @danharrin

@mmonari mmonari marked this pull request as draft October 2, 2024 16:38
@mmonari mmonari marked this pull request as ready for review October 2, 2024 16:39
@mmonari mmonari marked this pull request as draft October 2, 2024 16:39
@mmonari mmonari changed the base branch from 3.x to 4.x October 2, 2024 16:48
@mmonari mmonari marked this pull request as ready for review October 3, 2024 16:08
packages/actions/src/Exports/Exporter.php Outdated Show resolved Hide resolved
packages/actions/src/Exports/Jobs/CreateXlsxFile.php Outdated Show resolved Hide resolved
@danharrin danharrin added the enhancement New feature or request label Oct 7, 2024
@danharrin danharrin modified the milestones: v3, v4 Oct 7, 2024
@danharrin danharrin merged commit 59603da into filamentphp:4.x Oct 7, 2024
10 checks passed
@mmonari mmonari deleted the enhancement/xlsx-options branch October 7, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants