Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update resource namespace option in commands #14377

Open
wants to merge 1 commit into
base: 3.x
Choose a base branch
from

Conversation

wotta
Copy link

@wotta wotta commented Sep 28, 2024

Description

Added the missing option to set the resource namespace when calling make:filament-resource using the Artisan::call method.

Maybe a bit unusual PR but I ran into this while creating some functionality and have "clusters" enabled. While this is enabled I couldn't programmatically run this command anymore because there was no way of adding that option thus getting errors.
This change resolves it for me.

Visual changes

No visual changes unless you want a screenshot of the new command options. Just let me know😁

Functional changes

  • Code style has been fixed by running the composer cs command.
  • Changes have been tested to not break existing functionality.
  • Documentation is up-to-date.

@danharrin danharrin added the enhancement New feature or request label Oct 7, 2024
@danharrin danharrin added this to the v3 milestone Oct 7, 2024
@danharrin
Copy link
Member

Instead of this flag that just selects the first, shouldnt there be an argument where you pass in the name of the namespace, like the model namespace, so you can select a cluster if you need that? Because I find this PR quite confusing as a true/false option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

2 participants