Disable cells while table loading #13961
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zepfietje
reviewed
Aug 24, 2024
| @@ -96,6 +96,7 @@ | |||
| isLoading = false | |||
| " | |||
| :attributes="\Filament\Support\prepare_inherited_attributes($getExtraInputAttributeBag())" | |||
| wire:loading.attr="disabled" | |||
There was a problem hiding this comment.
Does this work reliably with line 78? I believe that was the main challenge.
There was a problem hiding this comment.
Hi, I'm not sure, but I can check!
There was a problem hiding this comment.
Yeah please check if you can :)
There was a problem hiding this comment.
Thanks for reminding me. I completely forgot 😅. I will check as soon as I can!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This was discussed in #7294. This PR aims to fix this issue with the exception of ToggleColumn, I tried but I couldnt get it to disable to during table loading. Maybe Zep knows more 👀
Thanks to @atmonshi for helping me!
Visual changes
Functional changes
composer cscommand.