Skip to content

Commit

Permalink
Remove query string usage from simple pages
Browse files Browse the repository at this point in the history
  • Loading branch information
danharrin committed Mar 14, 2024
1 parent 1f3b4e1 commit d2000c4
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 2 deletions.
15 changes: 13 additions & 2 deletions packages/actions/src/Concerns/InteractsWithActions.php
Original file line number Diff line number Diff line change
Expand Up @@ -40,13 +40,13 @@ trait InteractsWithActions
/**
* @var mixed
*/
#[Url(as: 'action')]
// #[Url(as: 'action')]
public $defaultAction = null;

/**
* @var mixed
*/
#[Url(as: 'actionArguments')]
// #[Url(as: 'actionArguments')]
public $defaultActionArguments = null;

/**
Expand All @@ -56,6 +56,17 @@ trait InteractsWithActions

protected bool $hasActionsModalRendered = false;

/**
* @return array<string, array<mixed>>
*/
protected function queryStringInteractsWithActions(): array
{
return [
'defaultAction' => ['as' => 'action'],
'defaultActionArguments' => ['as' => 'actionArguments'],
];
}

/**
* @param array<string, mixed> $arguments
*/
Expand Down
8 changes: 8 additions & 0 deletions packages/panels/src/Pages/SimplePage.php
Original file line number Diff line number Diff line change
Expand Up @@ -26,4 +26,12 @@ public function hasLogo(): bool
{
return true;
}

/**
* @return array<string, array<mixed>>
*/
protected function queryStringInteractsWithActions(): array
{
return [];
}
}

0 comments on commit d2000c4

Please sign in to comment.