Merge pull request #14220 from wout-o/3.x

fix: Parent modal not reopening after child modal is closed
filamentphp · Sep 12, 2024 · b4b6e1c · b4b6e1c
2 parents a56fc5e + fadeb66
commit b4b6e1c
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/packages/forms/src/Concerns/HasFormComponentActions.php b/packages/forms/src/Concerns/HasFormComponentActions.php
@@ -302,9 +302,7 @@ public function unmountFormComponentAction(bool $shouldCancelParentActions = tru
         }
 
         if (! count($this->mountedFormComponentActions)) {
-            if ($shouldCloseModal) {
-                $this->closeFormComponentActionModal();
-            }
+            $this->closeFormComponentActionModal($shouldCloseModal);
 
             return;
         }
@@ -314,9 +312,11 @@ public function unmountFormComponentAction(bool $shouldCancelParentActions = tru
         $this->openFormComponentActionModal();
     }
 
-    protected function closeFormComponentActionModal(): void
+    protected function closeFormComponentActionModal(bool $shouldCloseModal = true): void
     {
-        $this->dispatch('close-modal', id: "{$this->getId()}-form-component-action");
+        if ($shouldCloseModal) {
+            $this->dispatch('close-modal', id: "{$this->getId()}-form-component-action");
+        }
 
         $this->dispatch('closed-form-component-action-modal', id: $this->getId());
     }