Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Challenge fails with Connection refused (challenge type http-01) #37

Merged
merged 4 commits into from
Mar 18, 2020

Conversation

YetaWF
Copy link
Contributor

@YetaWF YetaWF commented Feb 29, 2020

#36

Adds a new StartUpMode option to define when cert requests/renewals are initiated.
StartupMode.Immediate (default) is identical to the current implementation.
StartUpMode.Manual requires an explicit call to app.RunFluffySpoonLetsEncrypt (at the end of Startup.Configure) to request/renew certs.
StartUpMode.Delayed defers until app.UseFluffySpoonLetsEncrypt is called.

…iated.

StartUpMode.Manual requires an explicit call to RunFluffySpoonLetsEncrypt.
@ffMathy
Copy link
Owner

ffMathy commented Feb 29, 2020

Instead of this, can we use a IApplicationLifetime to hook into when the application has started, and only start the timer at that time?

https://stackoverflow.com/q/57799344/553609

@YetaWF
Copy link
Contributor Author

YetaWF commented Feb 29, 2020

That's actually much better. Still using options? Or should this be the default? I didn't really like the options (StartUpMode), just wanted to get it working without disrupting anything.

@ffMathy
Copy link
Owner

ffMathy commented Feb 29, 2020

I'd prefer not to have the options as you mention yourself - the FluffySpoon packages are designed to be as simple to use as possible for solving very specific responsibilities, with minimal configuration options.

Sorry that you worked on this for nothing 😢

use IApplicationLifetime by default for startup
restore original hosted service def
@YetaWF
Copy link
Contributor Author

YetaWF commented Mar 18, 2020

I have updated the PR after your last comment to keep it with the minimal config approach. If the PR isn't appropriate, you can close it as I'm using a patched local version now anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants