Add policy for gcl and the gcl-generated binary for maxima #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's been over a month since I made this request, with no comments. What needs to be done to get some movement on this? Thank you. |
wrabcak
requested changes
Oct 16, 2017
| allow gcl_t self:process { execmem execheap }; | ||
|
|
||
| optional_policy(` | ||
| unconfined_domain(gcl_t) |
There was a problem hiding this comment.
You're trying to confine gcl processes but using this interface you make gcl unconfined. Is there any reason for this?
| role unconfined_r; | ||
| ') | ||
|
|
||
| gcl_run(unconfined_t, unconfined_r, { unconfined_tty_device_t unconfined_devpts_t }) |
There was a problem hiding this comment.
This should be part of unconfined SELinux module in fedora-selinux/selinux-policy repo.
| ') | ||
|
|
||
| optional_policy(` | ||
| gen_require(` |
There was a problem hiding this comment.
This require is not needed if you move gcl_run(...) into unconfined SELinux module.
wrabcak
force-pushed
the
rawhide
branch
2 times, most recently
from
c60cd73
to
e269450
Compare
|
Any update here? |
wrabcak
force-pushed
the
rawhide
branch
2 times, most recently
from
f4d327c
to
77dce4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just moves the existing policy files for gcl from gcl itself into the system selinux policy. I am by no means any kind of expert on writing selinux policy, so will gladly accept improvements or fixes. The hope is that not needing to build and install policy at gcl install time will fix https://bugzilla.redhat.com/show_bug.cgi?id=1435395.