Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #121

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Fixes #121

wants to merge 3 commits into from

Conversation

rdotjain
Copy link
Collaborator

@rdotjain rdotjain commented Apr 21, 2022

(1444c2e) Fixes #107 Added a getting started documentation.
(4086909) Fixes #110 General improvements for the device management tab.
(0108046) Fixes #88 Add option to 'forget' devices waiting to be claimed or already claimed

image

image

@runcom
Copy link
Member

runcom commented May 2, 2022

I think since this contains #119 and #120 you can add "Fixes " to the main comment? and close those two others

SETUP.md Outdated
```

2. Before installing other Python requirements, you need to install Apache httpd first. Follow the instructions from [mod-wsgi project documentation](https://pypi.org/project/mod-wsgi/).
<br>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed I think

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mod-wsgi documentation says that for installation of the module we need to have Apache installed first. During installation on MacOS, mod-wsgi was erroring out, brew installing httpd resolved the issue. But yeah, this might've been the issue just with my system.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be different for MacOS vs Linux.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be different for MacOS vs Linux.

@rdotjain rdotjain changed the title Add option to 'forget' devices waiting to be claimed or already claimed Fixes May 3, 2022
@nullr0ute
Copy link
Member

Overall this looks fine, I would improve the commit messages and update the PR and remove draft.

@rdotjain
Copy link
Collaborator Author

Overall this looks fine, I would improve the commit messages and update the PR and remove draft.

thanks for the review @nullr0ute

As this PR was doing multiple things, I opened a new PR #133 to particularly resolve "forget device" issue #88 and I think we can further refine the setup guide before merging this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants