New definition of "H", "L", "M", "T", new feature FORMS (if needed)

[Clayblockunova]

afaik from MDN, document.forms+[] returns to "[object HTMLCollection]" in most browsers, but idk how this actually work in old Android webview, so I created a new feature just in case (idk how to simulate, tho). btw, afaik, forms have a relatively shorter code in those similar properties of document, but idk is that the shortest.

[Clayblockunova]

what should I do?

[fasttime]

Thanks! I just need some time to look into this.

[fasttime]

It looks like there are already better definitions for all of the characters. Am I missing something?

[Clayblockunova]

It looks like there are already better definitions for all of the characters. Am I missing something?

you mean there is something better than forms?

[fasttime]

I think so. At least I could not find a case where the new definitions produce shorter code for some combination of browsers.

[Clayblockunova]

I think so. At least I could not find a case where the new definitions produce shorter code for some combination of browsers.

the expected combination is browsers except old Android web view.

[fasttime]

FORMS is available in Android Browser 4.0 and 4.1, but we still need the feature because it's not available in Node.js.

[Clayblockunova]

can we just treat that's part of ANY_DOCUMENT?

[fasttime]

can we just treat that's part of ANY_DOCUMENT?

I think it's easier to treat it as a separate feature. If we make ANY_DOCUMENT more specific we will also need to redefine DOCUMENT, and the emulation logic for both features.

[Clayblockunova]

and, the "V" definition based on document.createElement relies on ANY_DOCUMENT now. should we create a separate feature for this?

[Clayblockunova]

or should I add new simulation now? what should I do?

[fasttime]

and, the "V" definition based on document.createElement relies on ANY_DOCUMENT now. should we create a separate feature for this?

Yes, that would be better. I will split a new feature.

[Clayblockunova]

And, how to simulate?

[fasttime]

And, how to sumulate?

To emulate document.forms we can add a new property to the stub for document in the function makeEmuFeatureDocument:

JScrewIt/test/helpers/feature-emulation.helpers.js

Line 224 in 05243b9

document = { createElement: createElement, nodeName: '#document' };

for example:

                document =
                {
                    createElement:  createElement,
                    forms:          '[object HTMLCollection]',
                    nodeName:       '#document',
                };

[fasttime]

Nice work, thanks!