Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue24: Fixed the broken link view #31

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Fix for issue24: Fixed the broken link view #31

merged 1 commit into from
Oct 12, 2023

Conversation

rishijain
Copy link
Contributor

This is the fix for the #24 .

Screenshot before the fix:
Screenshot 2023-10-12 at 9 05 10 AM

Screenshot: after the fix
Screenshot 2023-10-12 at 9 03 27 AM

mateusdeap
mateusdeap approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@mateusdeap mateusdeap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me but any idea why we were using cycle in the show page?

@mateusdeap mateusdeap temporarily deployed to librarian-issue24-dwtus9eopfdp October 12, 2023 10:08 Inactive
@mateusdeap mateusdeap temporarily deployed to librarian-staging October 12, 2023 10:17 Inactive
@mateusdeap
Copy link
Member

I also deployed this branch to QA it and it is fixed

@JuanVqz JuanVqz merged commit 189873b into main Oct 12, 2023
1 check passed
@JuanVqz JuanVqz deleted the issue24 branch October 12, 2023 15:37
@etagwerker etagwerker mentioned this pull request Oct 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuanVqz JuanVqz JuanVqz approved these changes

@mateusdeap mateusdeap mateusdeap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rishijain @mateusdeap @JuanVqz