Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change grant_type password to client_credentials, add scope and client_secret #91

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Fosten
Copy link

@Fosten Fosten commented Apr 10, 2024

  • Password grant is no longer supported. Adds client_credentials.
  • Adds option for scope
  • Adds option for client_secret

Copy link
Member

@paul121 paul121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @Fosten :-) but... you can enable that contrib module to get password credentials as an option.

I'm less familiar with farmos.js, but could we allow there to be two OAuth options? One for password and one for client credentials?

In the next release of farmos.py I delegate this out to an external OAuth library. You instantiate your OAuth/Authentication method first and then bring that as an option when instantiating the farmOS client. It makes things a bit more flexible but does require one more step.

@braughtg
Copy link

braughtg commented Jul 1, 2024

Awesome @Fosten :-) but... you can enable that contrib module to get password credentials as an option.

It would be great to have both. I use the password credentials quite a bit in my test suite and it would be nice not to have to rebuild all of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants