Skip to content

Commit

Permalink
Do not delete descriptions if KeyErrors occured and prevent errors if…
Browse files Browse the repository at this point in the history
… there are no claims.
  • Loading branch information
fako committed Apr 19, 2017
1 parent b19af2a commit 5d4f54f
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions sources/models/wikipedia/data.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
from __future__ import unicode_literals, absolute_import, print_function, division
import six

from core.utils.helpers import override_dict
from sources.models.wikipedia.base import WikipediaAPI

Expand Down Expand Up @@ -59,7 +56,7 @@ def get_entity(self, snak):

def get_item(self, raw_item_data):
raw_claims = []
for raw_claims_list in six.itervalues(raw_item_data["claims"]):
for raw_claims_list in raw_item_data.get("claims", {}).values():
raw_claims += raw_claims_list
claim_entities = []
references = set()
Expand All @@ -84,9 +81,10 @@ def get_item(self, raw_item_data):
item = raw_item_data
try:
item["description"] = item["descriptions"]["en"]["value"]
del item["descriptions"]
except KeyError:
item["description"] = "No English description available"
del item["descriptions"]

item["claims"] = claim_entities
item["references"] = list(references)
return item
Expand Down

0 comments on commit 5d4f54f

Please sign in to comment.