Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Esp idf sys update #2

Merged
merged 1 commit into from
Jul 9, 2023
Merged

Esp idf sys update #2

merged 1 commit into from
Jul 9, 2023

Conversation

lorenzodellagiustina
Copy link
Contributor

Updated cargo toml with the new esp-idf-sys crate version

@faern
Copy link
Owner

faern commented Jul 4, 2023

Thank you for this contribution! Sorry for the slow response time. I have not spent much time doing embedded for a while :)

I filed esp-rs/esp-idf-sys#217 an issue regarding the incompatibility in OTA_SIZE_UNKNOWN. We'll see if that is fixed or not.

I get a warning about the unreachable! line in the restart method not being reachable code any longer. Seems like they finally fixed esp_restart to have the -> ! return type 🥳. But that means you should fix this in this PR also. I don't want any warnings.

@faern faern self-requested a review July 4, 2023 21:21
@lorenzodellagiustina
Copy link
Contributor Author

lorenzodellagiustina commented Jul 4, 2023 via email

@faern faern merged commit ccbba84 into faern:main Jul 9, 2023
@faern
Copy link
Owner

faern commented Jul 9, 2023

Thank you for the contribution. I went ahead and merged and fixed the outstanding issues. Also found we did not need to convert the chunk length to u32 any longer. This removed som unnecessary code 🥳

Also upgraded embuild to match that of esp-idf-sys to not pull in two versions.

Published as version 0.2.0. Even if the API itself did not change, upgrading esp-idf-sys is breaking since a project can't use two different versions of that dependency. https://crates.io/crates/esp-ota/0.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants