Fix video #23
Closed
Fix video #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: tsia Reviewed By: YLouWashU Differential Revision: D53844466 fbshipit-source-id: 913a7d76be4b47174f752e73761f1553a18f6103
Summary: Fixing typo. Plus a deprecated approach: https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html#summary. Reviewed By: chengshy Differential Revision: D54097958 fbshipit-source-id: effb53a054c35626e2f16578dccc5a57fc9a7403
Summary: CubeRCNN modeling needs to be imported first. `atek.model.cubercnn` has the imports. Pull Request resolved: #9 Reviewed By: YLouWashU Differential Revision: D54264215 Pulled By: zhengkang86 fbshipit-source-id: 1c0bd30ca9504d51768899d46644f3735a6a7a8f
Summary: 1. Enable category-based vs instance based training, via adding a `DATASETS.OBJECT_DETECTION_MODE` variable in the config yaml file. 2. Enable basic training in ASE datasets. The training seems to be (at least )up and running with following tensorboard results: 3.  Pull Request resolved: #10 Reviewed By: zhengkang86 Differential Revision: D54282791 Pulled By: YLouWashU fbshipit-source-id: 3f085cdd9d1eab93085f7ed7f0534bcceef1932a
Summary: This diff adds a unique file name for ADT-converted WDS datasets. Dev can specify a `dataset_prefix` string, which will further append `sequence_name` and `subtour_name` after it. The generated new filename will look like: `AsePublicRelease2023_100000_euston_simulation_100000_device0_fsg_000008` Reviewed By: zhengkang86 Differential Revision: D54293719 fbshipit-source-id: 65ccf38aeaa0a0947c326d1eecfeb8e0511768a6
Summary: Formats the covered files with pyfmt. paintitblack Reviewed By: aleivag Differential Revision: D54447727 fbshipit-source-id: 8844b1caa08de94d04ac4df3c768dbf8c865fd2f
Summary: As title. Reviewed By: zhengkang86 Differential Revision: D54399027 fbshipit-source-id: 8ccae7d1b452fcd4a5a04c990a6ae1c5b6e6f9db
Summary: It seems that ASE uses category name for mapping, while ADT uses Prototype name. This diff will enable either in `AdtGtDataProcessor`, and will determine which one to use by checking the header name in the taxonomy mapping file. Reviewed By: zhengkang86 Differential Revision: D54438232 fbshipit-source-id: 1fe42e70edc284f2e17e9837f064df130116164d
Summary: "Iteration" means something different in optimization than ML. So changing it to "batch", which means the current data "batch", to avoid confusion. Reviewed By: YLouWashU Differential Revision: D54543343 fbshipit-source-id: 925eca476db0a72f4cc158227797fc896be4964b
Summary: Create a Obb3 class to represent 3D bounding boxes Reviewed By: YLouWashU Differential Revision: D50849167 fbshipit-source-id: 78c0c7e446bef561f008ae428fcce20145d6b492
Reviewed By: YLouWashU Differential Revision: D50891167 fbshipit-source-id: a70814c141a637c9c3b67809e6fb9bdf277439e5
Summary: tsia Reviewed By: YLouWashU Differential Revision: D54640143 fbshipit-source-id: 3bad2672082b76edc7203503b7da6a49f71184cb
Summary: The 3D bounding box evaluator consists of two steps: 1) per-batch update: compute pairwise metrics (IoU, GIoU, etc) between prediction and GT, match pred to GT based on the match criterion (e.g., IoU > 0.25) 2) final eval: aggregate all true positives, false positives and false negatives to compute mean average precision (mAP) `eval_utils.py` is copied from https://www.internalfb.com/code/fbsource/fbcode/surreal/index/evaluation/metrics_compute.py to compute precision-recall curve, and mean average precision Reviewed By: YLouWashU Differential Revision: D54739283 fbshipit-source-id: 9fefcc21e829929dee97dd96140d9493fc9db3f1
Summary: Add evaluation callbacks in the inference pipeline to print and save evaluation results Reviewed By: YLouWashU Differential Revision: D54875155 Privacy Context Container: L11581 fbshipit-source-id: 39470850bea159c36a9072d94e16622212a5c1b6
Summary: tsia Reviewed By: YLouWashU Differential Revision: D54880351 Privacy Context Container: L11581 fbshipit-source-id: e79e043dc42874534305436c780b7c8bcafae153
Summary: Added Chamfer distance and Hungarian distance as metric to match predicted and GT 3D boxes Reviewed By: YLouWashU Differential Revision: D54913585 fbshipit-source-id: bffb508a26d4243a47a8bf88eb1b2205f62d72be
Summary: This diff changes the name of the file and class, because we plan to extend it to support MPS output. Reviewed By: zhengkang86 Differential Revision: D55042388 fbshipit-source-id: 8c31a866f01b90fc0d7d30ecf38766b0f8817ee9
Summary: Added three error metrics between predicted and GT 3D boxes: Euclidean distance, Geodesic angular error, diagonal error Euclidean distance can be used to associate/match predicted and GT 3D boxes Reviewed By: YLouWashU Differential Revision: D54913594 Privacy Context Container: L11581 fbshipit-source-id: a0b4a2e7306d0ed85c702d365c242192fa86e611
Summary: In the IOU/GIOU unit test, two convex hulls' intersection volume is verified by comparing to the results of `intersect_meshes` using trimesh API. Reviewed By: YLouWashU Differential Revision: D54399897 fbshipit-source-id: 3aa90d5085a4a7459a8c9651eb0c1f796c121361
Summary: Add unit tests for Chamfer distance, Hungarian distance, pairwise Chamfer distance, and pairwise Hungarian distance for a few simple cases Reviewed By: chengshy Differential Revision: D50867309 fbshipit-source-id: 7d51f98007680191f3ff1bd9f96560c00a65bd3f
Summary: Add unit tests for metrics between predicted and GT 3D boxes: Euclidean distance, Geodesic angular error, Diagonal error Reviewed By: YLouWashU Differential Revision: D51137891 fbshipit-source-id: 98a92d7e442bdcd6d00d359631ab939d6ee28874
Summary: Update omni3d_adapter to filter GT categories; Update evaluator to handle cases where no GT and no predictions are available; Update callback to skip saving prediction by default Reviewed By: YLouWashU Differential Revision: D55145188 fbshipit-source-id: 770027e091bb6268590a446243f5d04c70a5ecf8
Summary: As title. Reviewed By: zhengkang86 Differential Revision: D54978775 fbshipit-source-id: 93368db50dbdbc5c35ba9d81a46877c955f25388
Summary: This diff adds semidense point cloud to MpsProcessor. I will later break these into separate processors. Reviewed By: zhengkang86 Differential Revision: D54978776 fbshipit-source-id: e11e918195d1f692fc3c834ea66d124adbad0591
Summary: This diff adds a unit test for semidense point API in `MPSProcessor`. Reviewed By: zhengkang86 Differential Revision: D55048214 Privacy Context Container: L11581 fbshipit-source-id: 1c11c4698ca5f5f4a4155314b85c1552164105aa
Summary: Change semidense output format to DF, which is consistent with other data in current DataSchema. Reviewed By: zhengkang86 Differential Revision: D55883722 fbshipit-source-id: 61ed49ff2b632ccd9c0fdb3faac55ae982b6799d
Summary: As title. Reviewed By: zhengkang86 Differential Revision: D55883721 fbshipit-source-id: c04ae24b65bbb659abcb1c3301c415cd831c0a74
Summary: It seems that EFM needs inverse distance instead. Reviewed By: zhengkang86 Differential Revision: D55883723 Privacy Context Container: L11581 fbshipit-source-id: 54e0bfb45148b3c05096b3f817f6c90a69a7b0fe
Summary: as title Reviewed By: YLouWashU Differential Revision: D56552004 Privacy Context Container: L11581 fbshipit-source-id: 86d6a2169f6ea630d999cf33c7fb66c21c51ad8a
Summary: As title. Reviewed By: echo-xiao9 Differential Revision: D62609882 fbshipit-source-id: 0b950732ae41ce9b8cea0d4b2fcfca075b57b5db
Summary: Adds API to show rerun on notebook. Reviewed By: echo-xiao9 Differential Revision: D62986658 fbshipit-source-id: 7d016c88bd1280fb812af5e8ba7e0b89656a5e71
Summary: This diff moves `atek_v1` out of ATEK repo. Reviewed By: echo-xiao9 Differential Revision: D63153998 fbshipit-source-id: 5dc94188439aa6a6ce3d66d56eb6c6dec9fc328c
Summary: This diff prepares code for bug bash. Reviewed By: echo-xiao9 Differential Revision: D63069355 fbshipit-source-id: 356192ca7a1bc773daca17d8f2d35c080778b26a
Summary: As title Reviewed By: echo-xiao9 Differential Revision: D63072285 fbshipit-source-id: 7386359c835fbad2fdfc9ab974c795b31989488d
Summary: As title. Reviewed By: echo-xiao9 Differential Revision: D63162057 fbshipit-source-id: bf752f0434051aba8cb9cab101c623d1abf2cc0f
Summary: Global var is used wrong. This will be wrong when users do intermittent plotting. bboxes should be cleared at the beginning. Reviewed By: echo-xiao9 Differential Revision: D63170611 fbshipit-source-id: 8637f015537f0ed3da3bc3a7b8888858740cf8c1
Summary: As title. And also upgrading version to 1.0.0. Reviewed By: echo-xiao9 Differential Revision: D63203226 fbshipit-source-id: 8a6b51cc8cf4d548a67c213fff1e5ea305af54ec
Summary: as title. Reviewed By: YLouWashU Differential Revision: D63204945 fbshipit-source-id: 3401e4f0da68497100ca36db87aece66c4663731
Summary: As title. Reviewed By: echo-xiao9 Differential Revision: D63205256 fbshipit-source-id: 2cf83b78e26aa47f7fd71b09e564370b5709ba49
Summary: as title Reviewed By: YLouWashU Differential Revision: D63205323 Privacy Context Container: L1257120 fbshipit-source-id: ffcf2464f7595b3573d49885fcfad5a6a580a4f0
Summary: Fixing license headers. Reviewed By: echo-xiao9 Differential Revision: D63219081 fbshipit-source-id: d3dfb4c35c9ab5d923cf9d71f4e464f7940cb776
Summary: As title. Reviewed By: echo-xiao9 Differential Revision: D63235862 fbshipit-source-id: 24a176cf0d2878db1079bc1c0e8ae2fa3db6217e
Summary: Add official train validation split json file. Reviewed By: echo-xiao9 Differential Revision: D63238226 fbshipit-source-id: cf0b7dab830af9e890fd3783fa96b48ea6c21db6
Summary: 1. Remove a debug print. 2. Removed depth_anything code in SAM2 example. 3. Added Data Store config yaml files to data/ Reviewed By: echo-xiao9 Differential Revision: D63293449 fbshipit-source-id: a1073c02e8760a2a58e7d05dc8250cbb6c581618
Summary: As title. Reviewed By: echo-xiao9 Differential Revision: D63304852 fbshipit-source-id: 040bca0d88d3d58cb4b347e642a0644c5ed05fe5
Summary: Adding doc pages to ATEK. Reviewed By: echo-xiao9 Differential Revision: D63333948 fbshipit-source-id: 6fe3b946d3d598ed5b723b270a338e00eaebdc9e
Summary: Slightly revise information in the demo notebooks. Reviewed By: echo-xiao9 Differential Revision: D63337124 fbshipit-source-id: 6930816d085c48950554710065945a57ac4f8d9c
Summary: As title. Reviewed By: echo-xiao9 Differential Revision: D63349359 fbshipit-source-id: 30b74a726e7bcfdd1e6ea2b95c4b541913411bde
Summary: Adding video, and made minor fixes to docs. allow-large-files Reviewed By: echo-xiao9 Differential Revision: D63348509 fbshipit-source-id: 7e066911296a4b2518ef314d035433218c433fd2
Summary: Changing proper file link. Reviewed By: echo-xiao9 Differential Revision: D63357907 fbshipit-source-id: ce13eebd6de4d77551fce9ec861f92aaff67d432
…oaders/TARGETS Reviewed By: azad-meta Differential Revision: D63018396 fbshipit-source-id: b7af7a174404f6809ef4cdc9af3783ac301fb91e
Summary: As title. previous video file not playing. Reviewed By: echo-xiao9 Differential Revision: D63400521 fbshipit-source-id: 4738a6cde713ac1973dc1a5a7662b3817dcbbb9e
…s/atek/atek/data_loaders/TARGETS Differential Revision: D63018396 Original commit changeset: b7af7a174404 Original Phabricator Diff: D63018396 fbshipit-source-id: 6e965f824c87a04282512a18180142baec2a033b
Summary: As title. Reviewed By: chpeng-fb Differential Revision: D63406570 fbshipit-source-id: edf0bd345a83a2deeb99ef2fc8283fd704ef821a
facebook-github-bot
added
the
CLA Signed
facebook-github-bot
force-pushed
the
main
branch
from
264aab4
to
5ba66a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix video on front page