Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc: Support date_format Spark function by simply reusing a Presto function #11953

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

misc: Support date_format Spark function by simply reusing a Presto function #11953

wants to merge 2 commits into from
+9 −0

Conversation

PHILO-HE
Copy link
Contributor

@PHILO-HE PHILO-HE commented Dec 24, 2024 •
edited
Loading

This PR simply registers the existing FormatDateTimeFunction for Spark SQL to use.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 24, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 24, 2024 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 0fffe27
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/676b723d28646c0008e1fdf6

@PHILO-HE PHILO-HE changed the title misc: support date_format Spark function by simply reusing a Presto function misc: Support date_format Spark function by simply reusing a Presto function Dec 24, 2024
@PHILO-HE PHILO-HE mentioned this pull request Dec 24, 2024
Open
@PHILO-HE
Copy link
Contributor Author

We only use one signature of FormatDateTimeFunction. The other one is only applicable to Presto. So I prefer keeping the whole implementation in Presto folder.
@rui-mo, please take a look. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PHILO-HE @facebook-github-bot