Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add utilities for combining dictionary wrappers #11944

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

oerling
Copy link
Contributor

@oerling oerling commented Dec 24, 2024

  • Adds functions to transpose dictionaries with and without nulls.

  • Adds projection that wraps children of a RowVector into a dictionary so that dictionaries are combined instead of being nested. If multiple columns have the same wrapping indices, they continue to share the wrapping also after new indices are combined with the previous wrapper.

  • This is preparation for limiting dictionary wrapping to one level. This will speed up access and simplify corner cases of expressions.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 24, 2024
Copy link

netlify bot commented Dec 24, 2024

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit e3384c4
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/676a004e5d7ac30008d8b511

@facebook-github-bot
Copy link
Contributor

@oerling has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

- Adds functions to transpose dictionaries with and without nulls.

- Adds projection that wraps children of a RowVector into a dictionary
  so that dictionaries are combined instead of being nested. If
  multiple columns have the same wrapping indices, they continue to
  share the wrapping also after new indices are combined with the
  previous wrapper.

- This is preparation for limiting dictionary wrapping to one
  level. This will speed up access and simplify corner cases of
  expressions.
@facebook-github-bot
Copy link
Contributor

@oerling has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants