Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fuzzer): Update "makeDefaultPlan" function to generate multi-join plans #11939

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

DanielHunte
Copy link

Summary:
Generates a cascading multi-join from left to right.

[t1, t2, t3, t4]

t1  t2
 \  /
  a   t3
   \  /
     b   t4
      \  /
        c

Differential Revision: D67607316

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 23, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67607316

Copy link

netlify bot commented Dec 23, 2024

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit b279647
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/6769e8a633e7df0008da1fd3

DanielHunte pushed a commit to DanielHunte/velox that referenced this pull request Dec 23, 2024
…n plans (facebookincubator#11939)

Summary:

Generates a cascading multi-join from left to right.
```
[t1, t2, t3, t4]

t1  t2
 \  /
  a   t3
   \  /
     b   t4
      \  /
        c
```

Differential Revision: D67607316
DanielHunte pushed a commit to DanielHunte/velox that referenced this pull request Dec 23, 2024
…n plans (facebookincubator#11939)

Summary:

Generates a cascading multi-join from left to right.
```
[t1, t2, t3, t4]

t1  t2
 \  /
  a   t3
   \  /
     b   t4
      \  /
        c
```

Differential Revision: D67607316
Daniel Hunte added 3 commits December 23, 2024 14:47
… for reference query runners (facebookincubator#11801)

Summary:

Currently, the hash join and nested loop join "toSql" methods for all reference query runners only support a single join. This change extends it to support multiple joins, only needing the join node of the last join in the tree. It traverses up the tree and recursively builds the sql query.

Differential Revision: D66977480
…ns (facebookincubator#11938)

Summary:

The function should traverse the plan tree and recursively the sides of all join nodes that are eligible to be flipped.

Differential Revision: D67606686
…n plans (facebookincubator#11939)

Summary:

Generates a cascading multi-join from left to right.
```
[t1, t2, t3, t4]

t1  t2
 \  /
  a   t3
   \  /
     b   t4
      \  /
        c
```

Differential Revision: D67607316
DanielHunte pushed a commit to DanielHunte/velox that referenced this pull request Dec 23, 2024
…n plans (facebookincubator#11939)

Summary:

Generates a cascading multi-join from left to right.
```
[t1, t2, t3, t4]

t1  t2
 \  /
  a   t3
   \  /
     b   t4
      \  /
        c
```

Differential Revision: D67607316
DanielHunte pushed a commit to DanielHunte/velox that referenced this pull request Dec 23, 2024
…n plans (facebookincubator#11939)

Summary:

Generates a cascading multi-join from left to right.
```
[t1, t2, t3, t4]

t1  t2
 \  /
  a   t3
   \  /
     b   t4
      \  /
        c
```

Differential Revision: D67607316
DanielHunte pushed a commit to DanielHunte/velox that referenced this pull request Dec 23, 2024
…n plans (facebookincubator#11939)

Summary:

Generates a cascading multi-join from left to right.
```
[t1, t2, t3, t4]

t1  t2
 \  /
  a   t3
   \  /
     b   t4
      \  /
        c
```

Differential Revision: D67607316
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67607316

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants