-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fuzzer): Update "tryFlipJoinSides" functions to handle multi-joins #11938
Open
DanielHunte
wants to merge
2
commits into
facebookincubator:main
Choose a base branch
from
DanielHunte:export-D67606686
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Dec 23, 2024
This pull request was exported from Phabricator. Differential Revision: D67606686 |
✅ Deploy Preview for meta-velox canceled.
|
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 23, 2024
…ns (facebookincubator#11938) Summary: The function should traverse the plan tree and recursively the sides of all join nodes that are eligible to be flipped. Differential Revision: D67606686
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 23, 2024
…ns (facebookincubator#11938) Summary: The function should traverse the plan tree and recursively the sides of all join nodes that are eligible to be flipped. Differential Revision: D67606686
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 23, 2024
…ns (facebookincubator#11938) Summary: The function should traverse the plan tree and recursively the sides of all join nodes that are eligible to be flipped. Differential Revision: D67606686
… for reference query runners (facebookincubator#11801) Summary: Currently, the hash join and nested loop join "toSql" methods for all reference query runners only support a single join. This change extends it to support multiple joins, only needing the join node of the last join in the tree. It traverses up the tree and recursively builds the sql query. Differential Revision: D66977480
…ns (facebookincubator#11938) Summary: The function should traverse the plan tree and recursively the sides of all join nodes that are eligible to be flipped. Differential Revision: D67606686
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 23, 2024
…ns (facebookincubator#11938) Summary: The function should traverse the plan tree and recursively the sides of all join nodes that are eligible to be flipped. Differential Revision: D67606686
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 23, 2024
…ns (facebookincubator#11938) Summary: The function should traverse the plan tree and recursively the sides of all join nodes that are eligible to be flipped. Differential Revision: D67606686
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 23, 2024
…ns (facebookincubator#11938) Summary: The function should traverse the plan tree and recursively the sides of all join nodes that are eligible to be flipped. Differential Revision: D67606686
DanielHunte
force-pushed
the
export-D67606686
branch
from
December 23, 2024 22:48
53df0dc
to
5538665
Compare
This pull request was exported from Phabricator. Differential Revision: D67606686 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The function should traverse the plan tree and recursively the sides of all join nodes that are eligible to be flipped.
Differential Revision: D67606686