Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fuzzer): Update "tryFlipJoinSides" functions to handle multi-joins #11938

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

DanielHunte
Copy link

Summary: The function should traverse the plan tree and recursively the sides of all join nodes that are eligible to be flipped.

Differential Revision: D67606686

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 23, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67606686

Copy link

netlify bot commented Dec 23, 2024

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 5538665
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/6769e8abcae31b00081952b1

DanielHunte pushed a commit to DanielHunte/velox that referenced this pull request Dec 23, 2024
…ns (facebookincubator#11938)

Summary:

The function should traverse the plan tree and recursively the sides of all join nodes that are eligible to be flipped.

Differential Revision: D67606686
DanielHunte pushed a commit to DanielHunte/velox that referenced this pull request Dec 23, 2024
…ns (facebookincubator#11938)

Summary:

The function should traverse the plan tree and recursively the sides of all join nodes that are eligible to be flipped.

Differential Revision: D67606686
DanielHunte pushed a commit to DanielHunte/velox that referenced this pull request Dec 23, 2024
…ns (facebookincubator#11938)

Summary:

The function should traverse the plan tree and recursively the sides of all join nodes that are eligible to be flipped.

Differential Revision: D67606686
Daniel Hunte added 2 commits December 23, 2024 14:47
… for reference query runners (facebookincubator#11801)

Summary:

Currently, the hash join and nested loop join "toSql" methods for all reference query runners only support a single join. This change extends it to support multiple joins, only needing the join node of the last join in the tree. It traverses up the tree and recursively builds the sql query.

Differential Revision: D66977480
…ns (facebookincubator#11938)

Summary:

The function should traverse the plan tree and recursively the sides of all join nodes that are eligible to be flipped.

Differential Revision: D67606686
DanielHunte pushed a commit to DanielHunte/velox that referenced this pull request Dec 23, 2024
…ns (facebookincubator#11938)

Summary:

The function should traverse the plan tree and recursively the sides of all join nodes that are eligible to be flipped.

Differential Revision: D67606686
DanielHunte pushed a commit to DanielHunte/velox that referenced this pull request Dec 23, 2024
…ns (facebookincubator#11938)

Summary:

The function should traverse the plan tree and recursively the sides of all join nodes that are eligible to be flipped.

Differential Revision: D67606686
DanielHunte pushed a commit to DanielHunte/velox that referenced this pull request Dec 23, 2024
…ns (facebookincubator#11938)

Summary:

The function should traverse the plan tree and recursively the sides of all join nodes that are eligible to be flipped.

Differential Revision: D67606686
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67606686

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants