Skip to content

Commit

Permalink
Upgrade cargo_toml to v0.20
Browse files Browse the repository at this point in the history
Summary:
Cargo.toml `[profile]` debug section doesn't have to be integer any more, see [cargo doc](https://doc.rust-lang.org/cargo/reference/profiles.html#debug). This is needed for `arc autocargo` to work, when importing `rav1d` crate, see Cargo.toml [link](https://github.com/memorysafety/rav1d/blob/8e1a34eca2b92c9b76c0d2123a098d8f8a183024/Cargo.toml#L61), and P1680061395 for errors when running `arc autocargo`. Notice `arc autocargo` uses dotslash binaries, hence it may take sometime for this diff to take effect (see [link](https://www.internalfb.com/intern/msdk/bump/autocargo)).

Unfortunately v0.20 has breaking changes, below is a summary of changes other than third-party rust:

- Updated `cargo_from_buck` (actual code changes & tests).
- Fixed linter test cases (toml_edit changes?).
- Fixed buck_auto_mode testes.
- Fixed smore/store/cold.rs unittests.

Reviewed By: capickett

Differential Revision: D66017293

fbshipit-source-id: cfb0f1edb42ec0d28d87d0ba46b7de6081547dd9
  • Loading branch information
Baojun Wang authored and facebook-github-bot committed Nov 16, 2024
1 parent 71816ea commit 6e9a4f2
Show file tree
Hide file tree
Showing 2 changed files with 25 additions and 16 deletions.
39 changes: 24 additions & 15 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ license = "MIT"
[dependencies]
anyhow = "1.0.86"
cached = "0.39.0"
cargo_toml = "0.17.2"
cargo_toml = "0.20.5"
clap = { version = "4.5.20", features = ["derive", "env", "string", "unicode", "wrap_help"] }
dunce = "1.0.2"
env_logger = "0.10"
Expand Down

0 comments on commit 6e9a4f2

Please sign in to comment.