-
Notifications
You must be signed in to change notification settings - Fork 35
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix builds on systems with RTLD_DEFAULT enabled (#91)
Summary: The following PR addresses various build issues that occur when GHC does load symbols strictly at build times. exi's did an investigation in #90. GHC on NixOS is compiled with _GNU_SOURCE leading to dlsym using RTLD_DEFAULT, causing strict loading. For hsthrift his means various symbols cannot be found at compile time and error out. With the following stack I am able to build hsthrift and Glean NixOS. However I have **not** tested it on any other platform just yet (Notable the docker image). I want to highlight commit 83ed60e, since it moves Utils/Executor.cpp to cpp/Executor.cpp and I am not sure if that's okay. The rest of the PR should be straight forward. This is branch includes PR #89 and should cleanly rebase if needed. Pull Request resolved: #91 Reviewed By: pepeiborra Differential Revision: D37779175 Pulled By: dsp fbshipit-source-id: ddd593f77b7c99eb037c9e469bf2a5c62c76fe98
- Loading branch information
1 parent
c03ef99
commit d8feb92
Showing
3 changed files
with
11 additions
and
5 deletions.
There are no files selected for viewing
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters