Skip to content

Commit

Permalink
Create an enum for superconsole interaction toggles
Browse files Browse the repository at this point in the history
Summary:
Current implementation of console toggles relies on `char` and display is error-prone (.e.g we forgot to add `x` option to the Help). I initially tried to fix this in D60960924 but then realized that this could happen in the future. Better to make it type-safe so that we get it for free (via `strum::EnumIter`).

Also rename  `ConsoleInteraction` to `SuperConsoleInteraction`  to signify that these only for for superconsole.

Reviewed By: stepancheg

Differential Revision: D60965981

fbshipit-source-id: e0008b46dd752446b45877e6f0c2acf43f528c7b
  • Loading branch information
ezgicicek authored and facebook-github-bot committed Aug 12, 2024
1 parent 6cdbc72 commit f7c5fe7
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions shim/third-party/rust/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,7 @@ smallvec = { version = "1.10", features = ["const_generics", "const_new", "serde
static_assertions = "1.1.0"
strsim = "0.10.0"
structopt = "0.3.23"
strum = { version = "0.26.2", features = ["derive", "strum_macros"] }
syn = { version = "2", features = ["extra-traits", "full", "visit"] }
syn1 = { package = "syn", version = "1.0.109", features = ["extra-traits", "fold", "full", "visit", "visit-mut"] }
synstructure = "0.12"
Expand Down

0 comments on commit f7c5fe7

Please sign in to comment.