-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert directory fbcode/opensource to use the Ruff Formatter #3
Open
tpolasek
wants to merge
1
commit into
facebookexperimental:main
Choose a base branch
from
tpolasek:export-D64265365
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: X-link: facebookexperimental/edencommon#21 X-link: facebook/watchman#1248 X-link: facebook/wangle#239 X-link: facebook/sapling#968 X-link: facebook/proxygen#523 X-link: facebook/openr#156 X-link: facebook/mvfst#358 X-link: facebook/hhvm#9522 X-link: facebook/folly#2318 X-link: facebook/fboss#277 X-link: facebook/fb303#59 Converts the directory specified to use the Ruff formatter in pyfmt ruff_dog If this diff causes merge conflicts when rebasing, please run `hg status -n -0 --change . -I '**/*.{py,pyi}' | xargs -0 arc pyfmt` on your diff, and amend any changes before rebasing onto latest. That should help reduce or eliminate any merge conflicts. allow-large-files Reviewed By: amyreese Differential Revision: D64265365
facebook-github-bot
added
the
CLA Signed
This label is managed by the Meta Open Source bot.
label
Oct 18, 2024
This pull request was exported from Phabricator. Differential Revision: D64265365 |
tpolasek
pushed a commit
to tpolasek/rust-shed
that referenced
this pull request
Oct 18, 2024
Summary: X-link: facebookexperimental/moxygen#3 X-link: facebookexperimental/edencommon#21 X-link: facebook/watchman#1248 X-link: facebook/wangle#239 X-link: facebook/sapling#968 X-link: facebook/proxygen#523 X-link: facebook/openr#156 X-link: facebook/mvfst#358 X-link: facebook/hhvm#9522 X-link: facebook/folly#2318 X-link: facebook/fboss#277 X-link: facebook/fb303#59 Converts the directory specified to use the Ruff formatter in pyfmt ruff_dog If this diff causes merge conflicts when rebasing, please run `hg status -n -0 --change . -I '**/*.{py,pyi}' | xargs -0 arc pyfmt` on your diff, and amend any changes before rebasing onto latest. That should help reduce or eliminate any merge conflicts. allow-large-files Reviewed By: amyreese Differential Revision: D64265365
tpolasek
pushed a commit
to tpolasek/fizz
that referenced
this pull request
Oct 18, 2024
Summary: X-link: facebookexperimental/rust-shed#59 X-link: facebookexperimental/moxygen#3 X-link: facebookexperimental/edencommon#21 X-link: facebook/watchman#1248 X-link: facebook/wangle#239 X-link: facebook/sapling#968 X-link: facebook/proxygen#523 X-link: facebook/openr#156 X-link: facebook/mvfst#358 X-link: facebook/hhvm#9522 X-link: facebook/folly#2318 X-link: facebook/fboss#277 X-link: facebook/fb303#59 Converts the directory specified to use the Ruff formatter in pyfmt ruff_dog If this diff causes merge conflicts when rebasing, please run `hg status -n -0 --change . -I '**/*.{py,pyi}' | xargs -0 arc pyfmt` on your diff, and amend any changes before rebasing onto latest. That should help reduce or eliminate any merge conflicts. allow-large-files Reviewed By: amyreese Differential Revision: D64265365
tpolasek
pushed a commit
to tpolasek/hsthrift
that referenced
this pull request
Oct 18, 2024
Summary: X-link: facebookincubator/fizz#148 X-link: facebookexperimental/rust-shed#59 X-link: facebookexperimental/moxygen#3 X-link: facebookexperimental/edencommon#21 X-link: facebook/watchman#1248 X-link: facebook/wangle#239 X-link: facebook/sapling#968 X-link: facebook/proxygen#523 X-link: facebook/openr#156 X-link: facebook/mvfst#358 X-link: facebook/hhvm#9522 X-link: facebook/folly#2318 X-link: facebook/fboss#277 X-link: facebook/fb303#59 Converts the directory specified to use the Ruff formatter in pyfmt ruff_dog If this diff causes merge conflicts when rebasing, please run `hg status -n -0 --change . -I '**/*.{py,pyi}' | xargs -0 arc pyfmt` on your diff, and amend any changes before rebasing onto latest. That should help reduce or eliminate any merge conflicts. allow-large-files Reviewed By: amyreese Differential Revision: D64265365
tpolasek
pushed a commit
to tpolasek/katran
that referenced
this pull request
Oct 18, 2024
Summary: X-link: facebookincubator/hsthrift#141 X-link: facebookincubator/fizz#148 X-link: facebookexperimental/rust-shed#59 X-link: facebookexperimental/moxygen#3 X-link: facebookexperimental/edencommon#21 X-link: facebook/watchman#1248 X-link: facebook/wangle#239 X-link: facebook/sapling#968 X-link: facebook/proxygen#523 X-link: facebook/openr#156 X-link: facebook/mvfst#358 X-link: facebook/hhvm#9522 X-link: facebook/folly#2318 X-link: facebook/fboss#277 X-link: facebook/fb303#59 Converts the directory specified to use the Ruff formatter in pyfmt ruff_dog If this diff causes merge conflicts when rebasing, please run `hg status -n -0 --change . -I '**/*.{py,pyi}' | xargs -0 arc pyfmt` on your diff, and amend any changes before rebasing onto latest. That should help reduce or eliminate any merge conflicts. allow-large-files Reviewed By: amyreese Differential Revision: D64265365
afrind
pushed a commit
to afrind/moxygen
that referenced
this pull request
Dec 19, 2024
…MoQFlvReceiverClient (to test) Summary: 1- Audio track works (group/subg per obj)!!!! 2- Video track crashes the server (different err than before). See below: ``` ... V1213 09:08:36.445933 925420 MoQSession.cpp:1134] subscribeOk sess=0x51a000013900 V1213 09:08:36.446077 925420 MoQLocation.h:24] m=2 V1213 09:08:36.446148 925420 MoQLocation.h:55] g=0 o=0g=18446744073709551615 o=18446744073709551615 V1213 09:08:37.516494 925420 MoQSession.cpp:1953] onNewUniStream sess=0x51a000011b00 V1213 09:08:37.516966 925420 MoQSession.cpp:643] unidirectionalReadLoop sess=0x51a000011b00 F1213 09:08:37.548959 925420 MoQForwarder.h:270] Check failed: subgroupConsumerIt != sub->subgroups.end() *** Check failure stack trace: *** *** Aborted at 1734109717 (Unix time, try 'date -d 1734109717') *** *** Signal 6 (SIGABRT) (0x3113a000e1e3c) received by PID 925244 (pthread TID 0x7ff6e3600640) (linux TID 925420) (maybe from PID 925244, UID 201018) (code: -6), stack trace: *** ================================================================= ==925244==ERROR: AddressSanitizer: stack-use-after-return on address 0x7ff6e2403a50 at pc 0x7ff6eb667c02 bp 0x7ff6e8e90010 sp 0x7ff6e8e90008 READ of size 8 at 0x7ff6e2403a50 thread T1 SCARINESS: 61 (8-byte-read-stack-use-after-return) #0 0x7ff6eb667c01 in folly::AsyncStackRoot::getStackFramePointer() const fbcode/folly/tracing/AsyncStack-inl.h:135 #1 0x7ff6eb6677d6 in folly::symbolizer::getAsyncStackTraceSafe(unsigned long*, unsigned long) fbcode/folly/debugging/symbolizer/StackTrace.cpp:311 facebookexperimental#2 0x7ff6ed483896 in folly::symbolizer::SafeStackTracePrinter::printStackTrace(bool) fbcode/folly/debugging/symbolizer/Symbolizer.h:91 facebookexperimental#3 0x7ff6ef0b0607 in folly::symbolizer::(anonymous namespace)::innerSignalHandler(int, siginfo_t*, void*) fbcode/folly/debugging/symbolizer/SignalHandler.cpp:453 facebookexperimental#4 0x7ff6ef0aed81 in folly::symbolizer::(anonymous namespace)::signalHandler(int, siginfo_t*, void*) fbcode/folly/debugging/symbolizer/SignalHandler.cpp:474 ... ``` Differential Revision: D66176642
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: facebookexperimental/edencommon#21
X-link: facebook/watchman#1248
X-link: facebook/wangle#239
X-link: facebook/sapling#968
X-link: facebook/proxygen#523
X-link: facebook/openr#156
X-link: facebook/mvfst#358
X-link: facebook/hhvm#9522
X-link: facebook/folly#2318
X-link: facebook/fboss#277
X-link: facebook/fb303#59
Converts the directory specified to use the Ruff formatter in pyfmt
ruff_dog
If this diff causes merge conflicts when rebasing, please run
hg status -n -0 --change . -I '**/*.{py,pyi}' | xargs -0 arc pyfmt
on your diff, and amend any changes before rebasing onto latest.
That should help reduce or eliminate any merge conflicts.
allow-large-files
Reviewed By: amyreese
Differential Revision: D64265365