Skip to content
This repository has been archived by the owner on Jan 13, 2022. It is now read-only.

Update models.py #232

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update models.py #232

wants to merge 1 commit into from

Conversation

amaney
Copy link

@amaney amaney commented Jun 8, 2016

This will fix KeyError on entry['comments']['data'] when using a sandboxed app

This will fix KeyError on `entry['comments']['data']` when using a sandboxed app
@ghost
Copy link

ghost commented Jun 8, 2016

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

@ghost
Copy link

ghost commented Jun 8, 2016

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@ghost ghost added the CLA Signed label Jun 8, 2016
ritter-eb added a commit to ritter-eb/python-instagram that referenced this pull request Jun 15, 2016
ritter-eb added a commit to eventbrite/python-instagram that referenced this pull request Jun 15, 2016
@gteodoru
Copy link

when will this be merged

@ghost ghost added the CLA Signed label Jul 12, 2016
@deluss-c
Copy link

Looking forward to have it merged.

@rafael-h-ferreira
Copy link

rafael-h-ferreira commented Aug 19, 2016

The whole object_from_dictionary method relies too much on the dictionary structure. If one of those keys is not present, it raises exceptions.
Made a bigger modification regarding this issue: #237

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants