This repository has been archived by the owner on Mar 11, 2020. It is now read-only.
Fix broken link for local setup #87
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoelMarcey
reviewed
Aug 20, 2018
There was a problem hiding this comment.
@jimmynguyc Nice catch and thank you for the pull request.
Some comments inline.
| @@ -15,7 +15,7 @@ Platforms can have somewhat different visual styles, UI paradigms, or even techn | |||
|
|
|||
| #### Before We Start | |||
|
|
|||
| In this and subsequent tutorials, we're going to be diving into the code of the app itself, so you should [grab the source code](https://github.com/fbsamples/f8app) and clone it somewhere you can conveniently browse. You could also follow [our setup instructions](tutorials/building-the-f8-app/local-setup/) to use this to run the app yourself locally, but for the purposes of this tutorial, you just need to see the source code itself. | |||
| In this and subsequent tutorials, we're going to be diving into the code of the app itself, so you should [grab the source code](https://github.com/fbsamples/f8app) and clone it somewhere you can conveniently browse. You could also follow [our setup instructions](docs/en/1-A1-local-setup.html) to use this to run the app yourself locally, but for the purposes of this tutorial, you just need to see the source code itself. | |||
There was a problem hiding this comment.
Instead of linking directly to the html, it may be better to link to the markdown file instead in case we have translations or versioning enabled for this.
[our setup instructions](1-A1-setup.md)
| @@ -16,7 +16,7 @@ From a UI perspective, as platforms have somewhat different visual styles, UI pa | |||
|
|
|||
| #### Before We Start | |||
|
|
|||
| In this and subsequent tutorials, we're going to be diving into the code of the app itself, so you should [grab the source code](https://github.com/fbsamples/f8app) and clone it somewhere you can conveniently browse. You could also follow [our setup instructions](tutorials/building-the-f8-app/local-setup/) to use this to run the app yourself locally, but for the purposes of this tutorial, you just need to see the source code itself. | |||
| In this and subsequent tutorials, we're going to be diving into the code of the app itself, so you should [grab the source code](https://github.com/fbsamples/f8app) and clone it somewhere you can conveniently browse. You could also follow [our setup instructions](docs/en/1-A1-local-setup.html) to use this to run the app yourself locally, but for the purposes of this tutorial, you just need to see the source code itself. | |||
| @@ -16,7 +16,7 @@ Platforms can have somewhat different visual styles, UI paradigms, or even techn | |||
|
|
|||
| #### Before We Start | |||
|
|
|||
| In this and subsequent tutorials, we're going to be diving into the code of the app itself, so you should [grab the source code](https://github.com/fbsamples/f8app) and clone it somewhere you can conveniently browse. You could also follow [our setup instructions](tutorials/building-the-f8-app/local-setup/) to use this to run the app yourself locally, but for the purposes of this tutorial, you just need to see the source code itself. | |||
| In this and subsequent tutorials, we're going to be diving into the code of the app itself, so you should [grab the source code](https://github.com/fbsamples/f8app) and clone it somewhere you can conveniently browse. You could also follow [our setup instructions](docs/en/1-A1-local-setup.html) to use this to run the app yourself locally, but for the purposes of this tutorial, you just need to see the source code itself. | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://makeitopen.com/tutorials/building-the-f8-app/local-setup/ is a 404. Changing to https://makeitopen.com/docs/en/1-A1-local-setup.html instead