make hg tracebus size configurable with EdenConfig

Summary: make hg tracebus size configurable with EdenConfig Reviewed By: kmancini Differential Revision: D45256093 fbshipit-source-id: 20761aed368eb4cdecf4e116a3d3406cb83608c1
facebook · Apr 26, 2023 · 7ea1f24 · 7ea1f24
1 parent 3c4b3f7
commit 7ea1f24
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/eden/fs/config/EdenConfig.h b/eden/fs/config/EdenConfig.h
@@ -830,6 +830,11 @@ class EdenConfig : private ConfigSettingManager {
       25000,
       this};
 
+  ConfigSetting<size_t> HgTraceBusCapacity{
+      "telemetry:hg-tracebus-capacity",
+      100000,
+      this};
+
   /**
    * Controls whether EdenFS logs inode state changes to Tracebus or not.
    */

diff --git a/eden/fs/store/hg/HgQueuedBackingStore.cpp b/eden/fs/store/hg/HgQueuedBackingStore.cpp
@@ -43,13 +43,7 @@
 namespace facebook::eden {
 
 namespace {
-// 100,000 hg object fetches in a short term is plausible.
-constexpr size_t kTraceBusCapacity = 100000;
 static_assert(CheckSize<HgImportTraceEvent, 64>());
-// TraceBus is double-buffered, so the following capacity should be doubled.
-// 10 MB overhead per backing repo is tolerable.
-static_assert(
-    CheckEqual<6400000, kTraceBusCapacity * sizeof(HgImportTraceEvent)>());
 } // namespace
 
 HgImportTraceEvent::HgImportTraceEvent(
@@ -89,7 +83,9 @@ HgQueuedBackingStore::HgQueuedBackingStore(
       logger_(std::move(logger)),
       activityBuffer_{
           config_->getEdenConfig()->hgActivityBufferSize.getValue()},
-      traceBus_{TraceBus<HgImportTraceEvent>::create("hg", kTraceBusCapacity)} {
+      traceBus_{TraceBus<HgImportTraceEvent>::create(
+          "hg",
+          config_->getEdenConfig()->HgTraceBusCapacity.getValue())} {
   uint8_t numberThreads =
       config_->getEdenConfig()->numBackingstoreThreads.getValue();
   if (!numberThreads) {
-Original file line number
+Diff line change
@@ Expand Up / @@ -830,6 +830,11 @@ class EdenConfig : private ConfigSettingManager { @@
 ,
           this};
+      ConfigSetting<size_t> HgTraceBusCapacity{
+          "telemetry:hg-tracebus-capacity",
+,
+          this};
       /**
        * Controls whether EdenFS logs inode state changes to Tracebus or not.
        */
@@ Expand Down @@