Fix OSS build #518
Closed
Fix OSS build #518
+35
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D63148510 |
Summary: X-link: facebookincubator/zstrong#1007 facebook#510 git patches on Windows OSS proxygen builds been failing for a while because of new lines Windows vs Unix. I re-generated the patches on Windows and that seems to fix it, and it also works for linux builds so seems fine. Reviewed By: afrind, bigfootjon Differential Revision: D63148510
kvtsoy
force-pushed
the
export-D63148510
branch
from
669d899 to
6c397c1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63148510 |
facebook-github-bot
pushed a commit
to facebook/fb303
that referenced
this pull request
Oct 8, 2024
Summary: X-link: facebookincubator/zstrong#1007 X-link: facebook/proxygen#518 facebook/proxygen#510 git patches on Windows OSS proxygen builds been failing for a while because of new lines Windows vs Unix. I re-generated the patches on Windows and that seems to fix it, and it also works for linux builds so seems fine. Reviewed By: afrind, bigfootjon Differential Revision: D63148510 fbshipit-source-id: 0ee605896820784335c1acd2a3e22b3bdf8394f1
facebook-github-bot
pushed a commit
to facebookexperimental/edencommon
that referenced
this pull request
Oct 8, 2024
Summary: X-link: facebookincubator/zstrong#1007 X-link: facebook/proxygen#518 facebook/proxygen#510 git patches on Windows OSS proxygen builds been failing for a while because of new lines Windows vs Unix. I re-generated the patches on Windows and that seems to fix it, and it also works for linux builds so seems fine. Reviewed By: afrind, bigfootjon Differential Revision: D63148510 fbshipit-source-id: 0ee605896820784335c1acd2a3e22b3bdf8394f1
facebook-github-bot
pushed a commit
to facebookexperimental/rust-shed
that referenced
this pull request
Oct 8, 2024
Summary: X-link: facebookincubator/zstrong#1007 X-link: facebook/proxygen#518 facebook/proxygen#510 git patches on Windows OSS proxygen builds been failing for a while because of new lines Windows vs Unix. I re-generated the patches on Windows and that seems to fix it, and it also works for linux builds so seems fine. Reviewed By: afrind, bigfootjon Differential Revision: D63148510 fbshipit-source-id: 0ee605896820784335c1acd2a3e22b3bdf8394f1
|
This pull request has been merged in eaa20ff. |
facebook-github-bot
pushed a commit
to facebook/openr
that referenced
this pull request
Oct 8, 2024
Summary: X-link: facebookincubator/zstrong#1007 X-link: facebook/proxygen#518 facebook/proxygen#510 git patches on Windows OSS proxygen builds been failing for a while because of new lines Windows vs Unix. I re-generated the patches on Windows and that seems to fix it, and it also works for linux builds so seems fine. Reviewed By: afrind, bigfootjon Differential Revision: D63148510 fbshipit-source-id: 0ee605896820784335c1acd2a3e22b3bdf8394f1
facebook-github-bot
pushed a commit
to facebook/wangle
that referenced
this pull request
Oct 8, 2024
Summary: X-link: facebookincubator/zstrong#1007 X-link: facebook/proxygen#518 facebook/proxygen#510 git patches on Windows OSS proxygen builds been failing for a while because of new lines Windows vs Unix. I re-generated the patches on Windows and that seems to fix it, and it also works for linux builds so seems fine. Reviewed By: afrind, bigfootjon Differential Revision: D63148510 fbshipit-source-id: 0ee605896820784335c1acd2a3e22b3bdf8394f1
facebook-github-bot
pushed a commit
to facebook/mvfst
that referenced
this pull request
Oct 8, 2024
Summary: X-link: facebookincubator/zstrong#1007 X-link: facebook/proxygen#518 facebook/proxygen#510 git patches on Windows OSS proxygen builds been failing for a while because of new lines Windows vs Unix. I re-generated the patches on Windows and that seems to fix it, and it also works for linux builds so seems fine. Reviewed By: afrind, bigfootjon Differential Revision: D63148510 fbshipit-source-id: 0ee605896820784335c1acd2a3e22b3bdf8394f1
facebook-github-bot
pushed a commit
to facebookexperimental/moxygen
that referenced
this pull request
Oct 8, 2024
Summary: X-link: facebookincubator/zstrong#1007 X-link: facebook/proxygen#518 facebook/proxygen#510 git patches on Windows OSS proxygen builds been failing for a while because of new lines Windows vs Unix. I re-generated the patches on Windows and that seems to fix it, and it also works for linux builds so seems fine. Reviewed By: afrind, bigfootjon Differential Revision: D63148510 fbshipit-source-id: 0ee605896820784335c1acd2a3e22b3bdf8394f1
facebook-github-bot
pushed a commit
to facebook/fboss
that referenced
this pull request
Oct 8, 2024
Summary: X-link: facebookincubator/zstrong#1007 X-link: facebook/proxygen#518 facebook/proxygen#510 git patches on Windows OSS proxygen builds been failing for a while because of new lines Windows vs Unix. I re-generated the patches on Windows and that seems to fix it, and it also works for linux builds so seems fine. Reviewed By: afrind, bigfootjon Differential Revision: D63148510 fbshipit-source-id: 0ee605896820784335c1acd2a3e22b3bdf8394f1
facebook-github-bot
pushed a commit
to facebook/folly
that referenced
this pull request
Oct 8, 2024
Summary: X-link: facebookincubator/zstrong#1007 X-link: facebook/proxygen#518 facebook/proxygen#510 git patches on Windows OSS proxygen builds been failing for a while because of new lines Windows vs Unix. I re-generated the patches on Windows and that seems to fix it, and it also works for linux builds so seems fine. Reviewed By: afrind, bigfootjon Differential Revision: D63148510 fbshipit-source-id: 0ee605896820784335c1acd2a3e22b3bdf8394f1
facebook-github-bot
pushed a commit
to facebook/watchman
that referenced
this pull request
Oct 8, 2024
Summary: X-link: facebookincubator/zstrong#1007 X-link: facebook/proxygen#518 facebook/proxygen#510 git patches on Windows OSS proxygen builds been failing for a while because of new lines Windows vs Unix. I re-generated the patches on Windows and that seems to fix it, and it also works for linux builds so seems fine. Reviewed By: afrind, bigfootjon Differential Revision: D63148510 fbshipit-source-id: 0ee605896820784335c1acd2a3e22b3bdf8394f1
facebook-github-bot
pushed a commit
to facebookincubator/fizz
that referenced
this pull request
Oct 8, 2024
Summary: X-link: facebookincubator/zstrong#1007 X-link: facebook/proxygen#518 facebook/proxygen#510 git patches on Windows OSS proxygen builds been failing for a while because of new lines Windows vs Unix. I re-generated the patches on Windows and that seems to fix it, and it also works for linux builds so seems fine. Reviewed By: afrind, bigfootjon Differential Revision: D63148510 fbshipit-source-id: 0ee605896820784335c1acd2a3e22b3bdf8394f1
facebook-github-bot
pushed a commit
to facebookincubator/katran
that referenced
this pull request
Oct 8, 2024
Summary: X-link: facebookincubator/zstrong#1007 X-link: facebook/proxygen#518 facebook/proxygen#510 git patches on Windows OSS proxygen builds been failing for a while because of new lines Windows vs Unix. I re-generated the patches on Windows and that seems to fix it, and it also works for linux builds so seems fine. Reviewed By: afrind, bigfootjon Differential Revision: D63148510 fbshipit-source-id: 0ee605896820784335c1acd2a3e22b3bdf8394f1
facebook-github-bot
pushed a commit
to facebookincubator/hsthrift
that referenced
this pull request
Oct 8, 2024
Summary: X-link: facebookincubator/zstrong#1007 X-link: facebook/proxygen#518 facebook/proxygen#510 git patches on Windows OSS proxygen builds been failing for a while because of new lines Windows vs Unix. I re-generated the patches on Windows and that seems to fix it, and it also works for linux builds so seems fine. Reviewed By: afrind, bigfootjon Differential Revision: D63148510 fbshipit-source-id: 0ee605896820784335c1acd2a3e22b3bdf8394f1
facebook-github-bot
pushed a commit
to facebook/sapling
that referenced
this pull request
Oct 8, 2024
Summary: X-link: facebookincubator/zstrong#1007 X-link: facebook/proxygen#518 facebook/proxygen#510 git patches on Windows OSS proxygen builds been failing for a while because of new lines Windows vs Unix. I re-generated the patches on Windows and that seems to fix it, and it also works for linux builds so seems fine. Reviewed By: afrind, bigfootjon Differential Revision: D63148510 fbshipit-source-id: 0ee605896820784335c1acd2a3e22b3bdf8394f1
facebook-github-bot
pushed a commit
to facebook/fbthrift
that referenced
this pull request
Oct 8, 2024
Summary: X-link: facebookincubator/zstrong#1007 X-link: facebook/proxygen#518 facebook/proxygen#510 git patches on Windows OSS proxygen builds been failing for a while because of new lines Windows vs Unix. I re-generated the patches on Windows and that seems to fix it, and it also works for linux builds so seems fine. Reviewed By: afrind, bigfootjon Differential Revision: D63148510 fbshipit-source-id: 0ee605896820784335c1acd2a3e22b3bdf8394f1
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Oct 8, 2024
Summary: X-link: facebookincubator/zstrong#1007 X-link: facebook/proxygen#518 facebook/proxygen#510 git patches on Windows OSS proxygen builds been failing for a while because of new lines Windows vs Unix. I re-generated the patches on Windows and that seems to fix it, and it also works for linux builds so seems fine. Reviewed By: afrind, bigfootjon Differential Revision: D63148510 fbshipit-source-id: 0ee605896820784335c1acd2a3e22b3bdf8394f1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
#510
git patches on Windows OSS proxygen builds been failing for a while because of new lines Windows vs Unix.
I re-generated the patches on Windows and that seems to fix it, and it also works for linux builds so seems fine.
Differential Revision: D63148510