Update all .buckconfig/.gitignore/.watchmanconfig/buck.iml/.pyre_config to ignore .pylsp related folders #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D46668238 |
…ig to ignore .pylsp related folders (facebook#40) Summary: X-link: facebook/litho#951 Pull Request resolved: facebook#40 X-link: facebook/react-native#37866 X-link: pytorch/pytorch#103551 X-link: facebook/buck2-prelude#11 We're updating PYLS and Pyre to use .pylsp as isolation-prefix: D46599960, D46602539. We'd like to add these .pylsp to ignore folders to prevent users from having bunch of generated files listed in ISL. I went through every ".lsp-buck-out" and looked for references of .lsp and added new entries with .pylsp where necessary. There are few code mentions of .lsp-buck that seems relevant that I'll send out another diff for so that I can add the project owners. Differential Revision: D46668238 fbshipit-source-id: c10f4d8471579a8ad573fe5c8c213c96343d2552
inseokhwang
pushed a commit
to inseokhwang/pytorch
that referenced
this pull request
Jun 13, 2023
…ml/.pyre_config to ignore .pylsp related folders (pytorch#103551) Summary: X-link: facebook/litho#951 X-link: facebook/ocamlrep#40 X-link: facebook/react-native#37866 Pull Request resolved: pytorch#103551 X-link: facebook/buck2-prelude#11 We're updating PYLS and Pyre to use .pylsp as isolation-prefix: D46599960, D46602539. We'd like to add these .pylsp to ignore folders to prevent users from having bunch of generated files listed in ISL. I went through every ".lsp-buck-out" and looked for references of .lsp and added new entries with .pylsp where necessary. There are few code mentions of .lsp-buck that seems relevant that I'll send out another diff for so that I can add the project owners. Test Plan: reviewbylookingveryhard Differential Revision: D46668238 fbshipit-source-id: 9200b2c052d04db6610c033b30b73761b57679d0
inseokhwang
pushed a commit
to inseokhwang/react-native
that referenced
this pull request
Jun 13, 2023
…ig to ignore .pylsp related folders (facebook#37866) Summary: X-link: facebook/litho#951 X-link: facebook/ocamlrep#40 Pull Request resolved: facebook#37866 X-link: pytorch/pytorch#103551 X-link: facebook/buck2-prelude#11 We're updating PYLS and Pyre to use .pylsp as isolation-prefix: D46599960, D46602539. We'd like to add these .pylsp to ignore folders to prevent users from having bunch of generated files listed in ISL. I went through every ".lsp-buck-out" and looked for references of .lsp and added new entries with .pylsp where necessary. There are few code mentions of .lsp-buck that seems relevant that I'll send out another diff for so that I can add the project owners. Differential Revision: D46668238 fbshipit-source-id: aaca374be0bf27faf1d109e8c3a8bba9a1f8b706
inseokhwang
pushed a commit
to inseokhwang/buck2
that referenced
this pull request
Jun 13, 2023
…ig to ignore .pylsp related folders Summary: X-link: facebook/litho#951 X-link: facebook/ocamlrep#40 X-link: facebook/react-native#37866 X-link: pytorch/pytorch#103551 X-link: facebook/buck2-prelude#11 We're updating PYLS and Pyre to use .pylsp as isolation-prefix: D46599960, D46602539. We'd like to add these .pylsp to ignore folders to prevent users from having bunch of generated files listed in ISL. I went through every ".lsp-buck-out" and looked for references of .lsp and added new entries with .pylsp where necessary. There are few code mentions of .lsp-buck that seems relevant that I'll send out another diff for so that I can add the project owners. Differential Revision: D46668238 fbshipit-source-id: 64e9a34f444223847f9b58ee2c7f0fa925d08073
inseokhwang
force-pushed
the
export-D46668238
branch
from
d7670d3 to
9794cce
Compare
inseokhwang
pushed a commit
to inseokhwang/buck2-prelude
that referenced
this pull request
Jun 13, 2023
…ig to ignore .pylsp related folders (facebook#11) Summary: X-link: facebook/litho#951 X-link: facebook/ocamlrep#40 X-link: facebook/react-native#37866 X-link: pytorch/pytorch#103551 Pull Request resolved: facebook#11 We're updating PYLS and Pyre to use .pylsp as isolation-prefix: D46599960, D46602539. We'd like to add these .pylsp to ignore folders to prevent users from having bunch of generated files listed in ISL. I went through every ".lsp-buck-out" and looked for references of .lsp and added new entries with .pylsp where necessary. There are few code mentions of .lsp-buck that seems relevant that I'll send out another diff for so that I can add the project owners. Differential Revision: D46668238 fbshipit-source-id: 1ac7072c4aa68d26b54fe5e9522a532d77f2b21f
|
This pull request was exported from Phabricator. Differential Revision: D46668238 |
inseokhwang
pushed a commit
to inseokhwang/litho
that referenced
this pull request
Jun 13, 2023
…ig to ignore .pylsp related folders (facebook#951) Summary: Pull Request resolved: facebook#951 X-link: facebook/ocamlrep#40 X-link: facebook/react-native#37866 X-link: pytorch/pytorch#103551 X-link: facebook/buck2-prelude#11 We're updating PYLS and Pyre to use .pylsp as isolation-prefix: D46599960, D46602539. We'd like to add these .pylsp to ignore folders to prevent users from having bunch of generated files listed in ISL. I went through every ".lsp-buck-out" and looked for references of .lsp and added new entries with .pylsp where necessary. There are few code mentions of .lsp-buck that seems relevant that I'll send out another diff for so that I can add the project owners. Differential Revision: D46668238 fbshipit-source-id: a265a3d38990621e6860b61e352df7ad7383dfee
|
@inseokhwang I see the diff has been abandoned. Should I close this PR ? |
|
Hi @inseokhwang! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We're updating PYLS and Pyre to use .pylsp as isolation-prefix: D46599960, D46602539.
We'd like to add these .pylsp to ignore folders to prevent users from having bunch of generated files listed in ISL.
I went through every ".lsp-buck-out" and looked for references of .lsp and added new entries with .pylsp where necessary. There are few code mentions of .lsp-buck that seems relevant that I'll send out another diff for so that I can add the project owners.
Differential Revision: D46668238