Fix two race conditions in RecyclerBinder. #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the collection has not completed initial layout by the time onNewWorkingRange() is called, it will short circuit and not be called again. If a collection item has not completed initial layout by the time we attempt to check if it belongs to a working range, the call noop-s and is not attempted again. In each case, save the working range and apply it when the layout completes.
Fix two race conditions in RecyclerBinder.
|
Thank you for contributing 😃 |
|
Done! |
|
@pentiumao has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
pentiumao
requested changes
Dec 5, 2022
| @@ -2689,6 +2713,15 @@ private synchronized void commitResolutionResult( | |||
| if (mTreeState != null) { | |||
| mTreeState.unregisterRenderState(resolutionResult.treeState); | |||
| } | |||
|
|
|||
| WorkingRangeAndPositionHolder workingRangeAndPosition = null; | |||
| synchronized (this) { | |||
There was a problem hiding this comment.
This lock seems unnecessary, because commitResolutionResult is synchronized. Can we remove it?
| @@ -116,6 +118,9 @@ interface ComponentTreeMeasureListenerFactory { | |||
| @GuardedBy("this") | |||
| private int mLastRequestedHeightSpec = UNINITIALIZED; | |||
|
|
|||
| @GuardedBy("this") | |||
| private WorkingRangeAndPositionHolder mPendingWorkingRangeAndPosition = null; | |||
There was a problem hiding this comment.
Can we add @nullable to this field to make it Nullsafe?
| @@ -221,6 +223,8 @@ public void run() { | |||
| private final RunnableHandler mPreallocateMountContentHandler; | |||
| private final boolean mPreallocatePerMountSpec; | |||
|
|
|||
| private @Nullable WorkingRangeHolder mPendingWorkingRange; | |||
There was a problem hiding this comment.
This private field is never accessed, can you clarify its purpose? Thanks!
pentiumao
reviewed
Dec 7, 2022
| lastFullyVisibleIndex))); | ||
| } | ||
|
|
||
| synchronized void checkWorkingRangeAndDispatch( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If the collection has not completed initial layout by the time onNewWorkingRange() is called, it will short circuit and not be called again.
If a collection item has not completed initial layout by the time we attempt to check if it belongs to a working range, the call noop-s and is not attempted again.
In each case, save the working range and apply it when the layout completes.
Changelog
Fix two race conditions in RecyclerBinder.
Test Plan
Want to get feedback on my approach first.