Allow for custom ScrollStateDetector implementation #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change breaks the existing ScrollStateDetector implementation into two. It extracts an interface that users can potentially implement to provide their own ScrollStateDetector. It also creates an additional DefaultScrollStateDetector class that now contains the default ScrollStateDetector implementation.
This change adds onInterceptTouchEvent support to ScrollStateDetector and the relevant hooks in LithoScrollView and HorizontalScrollSpec. The implementation in the DefaultScrollStateDetector will be a no-op, because in that class all detection is done through onTouchEvent. Finally it also adds documentation in the ScrollStateDetector interface.
colriot
suggested changes
Feb 9, 2021
There was a problem hiding this comment.
Hi @chggr !
I've left a couple of comments below, but @arpitratan would probably add more after checking the actual functionally.
Can you also add a line to CHANGELOG.md about the new/changed functionality to keep everyone updated, please?
litho-it/src/test/java/com/facebook/litho/widget/DefaultScrollStateDetectorTest.java
Outdated
Show resolved
Hide resolved
litho-widget/src/main/java/com/facebook/litho/widget/HorizontalScrollSpec.java
Outdated
Show resolved
Hide resolved
litho-widget/src/main/java/com/facebook/litho/widget/VerticalScrollSpec.java
Outdated
Show resolved
Hide resolved
This change addds @nullable for ScrollStateDetector in both the HorizontalScrollSpec and VerticalScrollSpec. It also changes the method names in DefaultScrollStateDetectorTest to conform to the Litho standard.
|
Thanks @colriot for the review, great feedback! I have made all required changes, please let me know if there is anything else outstanding. Many thanks again and have a great day :-) |
|
Hi @arpitratan, @colriot, I hope you are well! Please let me know if you have any feedback on this PR. |
|
@colriot has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Support for a default ScrollStateDetector n HorizontalScrollSpec and VerticalScrollSpec was added
in a previous PR. This PR allows users to provide their own custom ScrollStateDetector implementation.
It breaks the existing ScrollStateDetector class into two: It extracts an interface that users can potentially
implement with their own functionality and also creates an additional DefaultScrollStateDetector that now
contains the default implementation to be used when no custom implementation has been specified.
Changelog
Allow for custom ScrollStateDetector implementations in HorizontalScrollSpec and VerticalScrollSpec.
Test Plan
This change has been tested via unit tests