Pass the pointer of owning object in GCHermesValueBase::set() #1512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62196480 |
|
This pull request was exported from Phabricator. Differential Revision: D62196480 |
lavenzg
added a commit
to lavenzg/hermes
that referenced
this pull request
Nov 8, 2024
…ok#1512) Summary: Pull Request resolved: facebook#1512 This variant will be used by write barriers that support large allocation in following diffs. Differential Revision: D62196480
lavenzg
force-pushed
the
export-D62196480-to-static_h
branch
from
e9b3ca5 to
a64eb4b
Compare
lavenzg
added a commit
to lavenzg/hermes
that referenced
this pull request
Nov 14, 2024
…ok#1512) Summary: Pull Request resolved: facebook#1512 This variant will be used by write barriers that support large allocation in following diffs. Differential Revision: D62196480
lavenzg
force-pushed
the
export-D62196480-to-static_h
branch
from
a64eb4b to
8e20882
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62196480 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D62196480 |
lavenzg
added a commit
to lavenzg/hermes
that referenced
this pull request
Nov 21, 2024
…ok#1512) Summary: Pull Request resolved: facebook#1512 This variant will be used by write barriers that support large allocation in following diffs. Differential Revision: D62196480
lavenzg
force-pushed
the
export-D62196480-to-static_h
branch
from
8e20882 to
2940a2c
Compare
lavenzg
added a commit
to lavenzg/hermes
that referenced
this pull request
Nov 23, 2024
…ok#1512) Summary: Pull Request resolved: facebook#1512 This variant will be used by write barriers that support large allocation in following diffs. Differential Revision: D62196480
lavenzg
force-pushed
the
export-D62196480-to-static_h
branch
from
2940a2c to
9795500
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62196480 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D62196480 |
lavenzg
added a commit
to lavenzg/hermes
that referenced
this pull request
Nov 28, 2024
…ok#1512) Summary: Pull Request resolved: facebook#1512 This variant will be used by write barriers that support large allocation in following diffs. Differential Revision: D62196480
lavenzg
force-pushed
the
export-D62196480-to-static_h
branch
from
9795500 to
c2647ef
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62196480 |
lavenzg
force-pushed
the
export-D62196480-to-static_h
branch
from
c2647ef to
5e185a1
Compare
lavenzg
added a commit
to lavenzg/hermes
that referenced
this pull request
Dec 2, 2024
…ok#1512) Summary: Pull Request resolved: facebook#1512 This variant will be used by write barriers that support large allocation in following diffs. Differential Revision: D62196480
lavenzg
added a commit
to lavenzg/hermes
that referenced
this pull request
Dec 10, 2024
…ok#1512) Summary: Pull Request resolved: facebook#1512 This variant will be used by write barriers that support large allocation in following diffs. Differential Revision: D62196480
lavenzg
force-pushed
the
export-D62196480-to-static_h
branch
from
5e185a1 to
d18b763
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62196480 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D62196480 |
lavenzg
added a commit
to lavenzg/hermes
that referenced
this pull request
Dec 22, 2024
…ok#1512) Summary: Pull Request resolved: facebook#1512 This variant will be used by write barriers that support large allocation in following diffs. Differential Revision: D62196480
lavenzg
force-pushed
the
export-D62196480-to-static_h
branch
from
d18b763 to
03b0589
Compare
Differential Revision: D66727534
Differential Revision: D61675022
…er (facebook#1504) Summary: Pull Request resolved: facebook#1504 Large segment needs to be backed by a large storage size. StorageProvider currently always allocate fixed size of storage determined by HERMESVM_LOG_HEAP_SEGMENT_SIZE. This diffs adds support of allocating larger storage with below changes: 1. `newStorage()` and `deleteStorage()` takes additional `sz` parameter. 2. For `MallocStorageProvider` and `VMAllocateStorageProvider`, simply change the previous fixed storage size to passed in `sz`. 3. For `ContiguousVAStorageProvider`, use a BitVector to manage allocations and deallocations. This can be improved later if we observe fragmentations. The support of enabling different sizes of heap segment will be added later. Differential Revision: D61676721
Differential Revision: D61807366
…ize in base calss Differential Revision: D65828323
Differential Revision: D61747510
…s to AlignedHeapSegmentBase Differential Revision: D64713261
Differential Revision: D65638502
Differential Revision: D62171114
…ers (facebook#1513) Summary: Pull Request resolved: facebook#1513 Differential Revision: D62169632
… start address Differential Revision: D67481895
Differential Revision: D65701671
Differential Revision: D67556001
…ok#1512) Summary: Pull Request resolved: facebook#1512 This variant will be used by write barriers that support large allocation in following diffs. Differential Revision: D62196480
|
This pull request was exported from Phabricator. Differential Revision: D62196480 |
lavenzg
force-pushed
the
export-D62196480-to-static_h
branch
from
03b0589 to
67dd50c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add this parameter so that it could be passed to write barrier function
in following diffs. For not it's unused.
We don't create a overload or make a default parameter value because
it's error prone: new code may call wrong functions (unless reasoning
whether the object lives in normal segment or large segment), or forget
to update existing calls. It's actually easier to just always pass in
the owning object pointer, which in most cases is obvious to get.
Differential Revision: D62196480