Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix running test262 #1412

Open
wants to merge 1 commit into
base: static_h
Choose a base branch
from

Conversation

lavenzg
Copy link
Contributor

@lavenzg lavenzg commented May 30, 2024

Differential Revision: D57977650

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label May 30, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57977650

@lavenzg lavenzg force-pushed the export-D57977650-to-static_h branch from 6726ea9 to 5c222b6 Compare May 30, 2024 21:26
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57977650

@lavenzg lavenzg force-pushed the export-D57977650-to-static_h branch from 5c222b6 to 3519df0 Compare May 30, 2024 21:49
lavenzg added a commit to lavenzg/hermes that referenced this pull request May 30, 2024
Summary:

Call the new test runner entry.

Differential Revision: D57977650
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57977650

Summary:

Call the new test runner entry and fix the logic with "--test-intl",
now it won't try to update the skiplist config without providing 
"--test-skiplist" together. Update the config w.r.t. to INTL as well.

Differential Revision: D57977650
@lavenzg lavenzg force-pushed the export-D57977650-to-static_h branch from 3519df0 to 912350f Compare May 31, 2024 00:07
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57977650

facebook-github-bot pushed a commit that referenced this pull request May 31, 2024
Summary:
Pull Request resolved: #1412

Call the new test runner entry and fix the logic with "--test-intl",
now it won't try to update the skiplist config without providing
"--test-skiplist" together. Update the config w.r.t. to INTL as well.

Reviewed By: avp

Differential Revision: D57977650

fbshipit-source-id: cd5250184b35880440546138c3833dc462dc9c03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants