Reduce ASAN native stack check gap

Summary: Original Author: [email protected] Original Git: be237c7 Original Reviewed By: tmikov Original Revision: D67346000 This was causing RangeErrors to be reported too early in ASAN, and reducing it by half doesn't appear to cause crashes in any tests. Reviewed By: tmikov Differential Revision: D67410290 fbshipit-source-id: 27c8f2f8e4e1181385874eb3c0a99790586f6d82
facebook · Dec 19, 2024 · e28fd47 · e28fd47
1 parent 817a35b
commit e28fd47
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/include/hermes/VM/Runtime.h b/include/hermes/VM/Runtime.h
@@ -1626,7 +1626,7 @@ class ScopedNativeDepthReducer {
   // This is empirically good enough.
   static constexpr int kReducedNativeStackGap =
 #if LLVM_ADDRESS_SANITIZER_BUILD
-      256 * 1024;
+      128 * 1024;
 #else
       32 * 1024;
 #endif

diff --git a/lib/VM/Runtime.cpp b/lib/VM/Runtime.cpp
@@ -87,7 +87,7 @@ static constexpr uint32_t kMaxSupportedNumRegisters =
 /// The minimum stack gap allowed from RuntimeConfig.
 static constexpr uint32_t kMinSupportedNativeStackGap =
 #if LLVM_ADDRESS_SANITIZER_BUILD
-    512 * 1024;
+    256 * 1024;
 #else
     64 * 1024;
 #endif
-Original file line number
+Diff line change
@@ Expand Up / @@ -1626,7 +1626,7 @@ class ScopedNativeDepthReducer { @@
       // This is empirically good enough.
       static constexpr int kReducedNativeStackGap =
     #if LLVM_ADDRESS_SANITIZER_BUILD
-* 1024;
+* 1024;
     #else
 * 1024;
     #endif
@@ Expand Down @@