Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FLOWLIB_ROOT variable to flowconfig #7732

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

goodmind
Copy link
Contributor

@goodmind goodmind commented May 16, 2019

This would allow ignoring specific libs

# node.flowconfig
[ignore]
<FLOWLIB_ROOT>/dom.js
# browser.flowconfig
[ignore]
<FLOWLIB_ROOT>/react.js
<FLOWLIB_ROOT>/react-dom.js

@goodmind
Copy link
Contributor Author

goodmind commented May 16, 2019

Ignoring core.js should probably enable no_flowlib automatically. Or just ditch no_flowlib entirely and make it variation of

# no_flowlib = true
[ignore]
<FLOWLIB_ROOT>/.*
!<FLOWLIB_ROOT>/prelude.js

[include]
<FLOWLIB_ROOT>/prelude.js

# no_flowlib = false
[ignore]
<FLOWLIB_ROOT>/prelude.js

[include]
<FLOWLIB_ROOT>/.*
!<FLOWLIB_ROOT>/prelude.js

@goodmind goodmind added the Stalled Issues and PRs that are stalled. label Jul 27, 2019
@goodmind
Copy link
Contributor Author

/cc @gabelevi

@goodmind goodmind removed the Stalled Issues and PRs that are stalled. label Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants