Add strict mode assert typedefs #7660
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goodmind
added
the
Library definitions
| ok(value: any, message?: string): void; | ||
| fail(message?: string | Error): void; | ||
| // deprecated since v10.15 | ||
| fail(actual: any, expected: any, message: string, operator: string): void; |
There was a problem hiding this comment.
Should we update assert.fail the same way it's done there #7915?
|
/cc @gabelevi probably |
There was a problem hiding this comment.
@nmote has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
I had to add the inexact type syntax and record the tests after rebasing, but otherwise the rebased version was unchanged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7217
Revived #7401
https://nodejs.org/api/assert.html#assert_strict_mode