Allow event name symbols in events$EventEmitter. #7485
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
There was a problem hiding this comment.
@mvitousek has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
nmote
added
the
Library definitions
|
This change looks correct, thank you for the PR! This does change the output of some tests, would you mind regenerating the expected test outputs for node_tests (with ./runtests -r) and adding that to the PR? |
mirek
force-pushed
the
event-emitter-symbols
branch
from
fc36949 to
583730b
Compare
events$EventEmittermethods support Symbol as eventName https://nodejs.org/api/events.html#events_emitter_addlistener_eventname_listener - make sure flow library definition does match nodejs.